Allow v2 provider backends#1106
Merged
Merged
Conversation
mtreinish
approved these changes
Jan 20, 2021
Member
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, it'd be good to have a test here, but the easy way to go about that using a fake backend won't work yet because the fake backends are still legacy backends. We can circle back here after we have some local new interface backends that will work.
mtreinish
added
the
stable-backport-potential
mtreinish
pushed a commit
to mtreinish/qiskit-aer
that referenced
this pull request
Mar 3, 2021
Modified to handle backwards compatibility with older versions of qiskit terra prior to the Backend abstract class existing. (cherry picked from commit 450ae96)
mtreinish
added a commit
to mtreinish/qiskit-aer
that referenced
this pull request
Mar 4, 2021
During code review it was suggested to change the try except logic around importing Backend from terra that was added in the backport for PR Qiskit#1106 for backwards compatibility with the minimum supported terra version to a simpler version using tuples. This commit makes that change to avoid a needlessly long if statement around isinstance checking backend objects. Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
mtreinish
added a commit
to mtreinish/qiskit-aer
that referenced
this pull request
Mar 4, 2021
During code review it was suggested to change the try except logic around importing Backend from terra that was added in the backport for PR Qiskit#1106 for backwards compatibility with the minimum supported terra version to a simpler version using tuples. This commit makes that change to avoid a needlessly long if statement around isinstance checking backend objects. Co-authored-by: Christopher J. Wood <cjwood@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Qiskit/qiskit#5086 introduced v2 provider with new classes
Backend,Job, andProvider.ibmq-provideris switching to v2 provider interface, and this PR ensures thatBackendwill be accepted in addition toBaseBackend.Details and comments