Skip to content

Resolving comments from ZIP Editors#96

Merged
vivek-arte merged 6 commits into
zsa1from
zip_editor_fix
Feb 4, 2025
Merged

Resolving comments from ZIP Editors#96
vivek-arte merged 6 commits into
zsa1from
zip_editor_fix

Conversation

@vivek-arte
Copy link
Copy Markdown

This PR makes various changes based on the comments on zcash#960 made during ZIP Editor syncs.

@vivek-arte vivek-arte marked this pull request as draft January 30, 2025 10:07
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 30, 2025

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit 30125b9
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/67a2590854eb670008d403a4
😎 Deploy Preview https://deploy-preview-96--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vivek-arte vivek-arte added the ZSAs label Feb 3, 2025
@vivek-arte vivek-arte marked this pull request as ready for review February 4, 2025 17:47
@vivek-arte vivek-arte requested a review from PaulLaux February 4, 2025 17:47
Copy link
Copy Markdown

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with minor comments

Comment thread zips/zip-0226.rst Outdated
Comment thread zips/zip-0227.rst Outdated
Comment thread zips/zip-0227.rst Outdated
Comment thread zips/zip-0227.rst
We define a function $\mathsf{DeriveIssuedRho} : \mathbb{F}_{q_{\mathbb{P}}} \times \{0 .. 2^{32} - 1\} \times \{0 .. 2^{32} - 1\} \to \mathbb{F}_{q_{\mathbb{P}}}$ for Issue Notes in the OrchardZSA Protocol as follows:

.. math:: \mathsf{DeriveIssuedRho}(\mathsf{nf}, \mathsf{i_{A}}, \mathsf{i_{N}}) := \mathsf{ToBase}^{\mathsf{Rho}}(\mathsf{PRF}^{\mathsf{Rho}}(\mathsf{I2LEOSP}_{256}(\mathsf{nf}), [\mathtt{0x84}] \| \mathsf{I2LEOSP}_{32}(\mathsf{i_{A}}) \| \mathsf{I2LEOSP}_{32}(\mathsf{i_{N}}))),
.. math:: \mathsf{DeriveIssuedRho}(\mathsf{nf}, \mathsf{i_{A}}, \mathsf{i_{N}}) := \mathsf{ToBase}^{\mathsf{Orchard}}(\mathsf{PRF}^{\mathsf{expand}}(\mathsf{I2LEOSP}_{256}(\mathsf{nf}), [\mathtt{0x84}] \| \mathsf{I2LEOSP}_{32}(\mathsf{i_{A}}) \| \mathsf{I2LEOSP}_{32}(\mathsf{i_{N}}))),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later, please make sure that this is complient with the code.

@vivek-arte vivek-arte merged commit b5b434c into zsa1 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants