[ZSA][Fees] Refactoring the ZSA Fees#71
Merged
Merged
Conversation
… the issuance_fee as a multiple of the marginal_fee
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vivek-arte
changed the title
PaulLaux
reviewed
Oct 7, 2024
daira
reviewed
Nov 3, 2024
daira
reviewed
Nov 3, 2024
PaulLaux
approved these changes
Nov 3, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Confirmed after fixing all comments.
Also, every time you mention "the protocol" use "the OrchardZSA Protocol" for consistency.
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
reviewed
Nov 4, 2024
There was a problem hiding this comment.
It's fine to merge this into your branch. It should not be merged to zcash/zips yet, since it would make draft changes to a Released ZIP, which I have proposed should be avoided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.