Improved description of the burn mechanism, and rationale for asset description string size#61
Merged
Merged
Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PaulLaux
reviewed
Sep 18, 2024
PaulLaux
approved these changes
Sep 24, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
One comment, please add: The OrchardZSA protocol does not allow to burn ZEC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the burn mechanism description in ZIP 226 in order to remove some ambiguously defined terms, and improve the clarity of the specification.
It also adds the rationale for the choice of 512 bytes for the maximum length of the asset description string in ZIP 227, which resolves zcash#843 (along with the additions in the already merged #59)