Closed
Conversation
PaulLaux
commented
Feb 12, 2023
PaulLaux
commented
Feb 12, 2023
Author
|
implemented in QED-it/orchard#44 |
vivek-arte
reviewed
Feb 17, 2023
vivek-arte
force-pushed
the
assetId_review
branch
from
b098bba to
79e44c9
Compare
Author
|
@vivek-arte Should we close this PR? Or the personalization issue is still open? |
Author
|
@vivek-arte should we close it? |
|
The personalization issue was handled, and the other comments have been incorporated in other PRs. I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added my comments.
In addition, should check all 3 zips from top to bottom and make sure the change
assetId->assertBaseis properly handled.