Removed redundant terminology in ZIP226, building on ZIP227#26
Merged
Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vivek-arte
approved these changes
Jun 6, 2023
vivek-arte
left a comment
vivek-arte
left a comment
There was a problem hiding this comment.
Approved with a couple of suggestions. @PaulLaux, if you have any preference for "issuance" vs "creation" in my suggestion, please let us know?
vivek-arte
reviewed
Jun 6, 2023
Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
PaulLaux
pushed a commit
that referenced
this pull request
Oct 4, 2023
Removed redundant terminology in ZIP226, building on ZIP227, fixed abstract and used consistent terminology to stick to issuance instead of creation of assets. --------- Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
vivek-arte
added a commit
that referenced
this pull request
Feb 12, 2024
Removed redundant terminology in ZIP226, building on ZIP227, fixed abstract and used consistent terminology to stick to issuance instead of creation of assets. Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #20, I defined common terms to both ZIPs in 227 to draw a cleaner connection between 227 and 226 and avoid taking the reader back and forth between both (227 is prerequisite for 226, yet some terms were defined in 226).
Now that #20 has been merged, this PR cascades this changes to 226, referring to 227 for common terms and revamping the abstract accordingly.