Rearranging ZIP structure#14
Merged
Merged
Conversation
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vivek-arte
force-pushed
the
restructuring_and_applying_comments
branch
from
1eda4a4 to
a816b67
Compare
vivek-arte
force-pushed
the
restructuring_and_applying_comments
branch
from
c4f890d to
ca384a2
Compare
* removing conflicting entry in requirements regarding private allocation of issuance notes; * adding info about issueAuthSig validation.
… be UTF-8 rather than mandated to be so.
…rrangement, other aesthetic changes
vivek-arte
force-pushed
the
restructuring_and_applying_comments
branch
from
0e9d8b7 to
aa9d676
Compare
PaulLaux
approved these changes
May 8, 2023
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Great work,
Approved with pending changes.
| This :math:`\mathsf{AssetBase}^{\mathsf{Orchard}}` will be the base point of the value commitment for the specific Custom Asset. Note that the :math:`\mathsf{AssetBase}^{\mathsf{Orchard}}` of the ZEC Asset will be kept as the original value base point, :math:`\mathcal{V}^\mathsf{Orchard}`. | ||
|
|
||
| In future network and protocol upgrades, the same Asset description string can be carried on, potentially mapping into a different shielded protocol. In that case, the turnstile should know how to transform the Asset Identifier, :math:`\mathsf{AssetId}`, the Asset Digest, and the Asset Base from one shielded protocol to another. | ||
| In future network and protocol upgrades, the same Asset description string can be carried on, potentially mapping into a different shielded pool. In that case, nodes should know how to transform the Asset Identifier, :math:`\mathsf{AssetId}`, the Asset Digest, and the Asset Base from one shielded pool to another, while ensuring there are no balance violations [#zip-0209]_. |
There was a problem hiding this comment.
Please add subtitle above this sentence Rational for Asset Identifiers
Author
There was a problem hiding this comment.
Is this sentence a rationale? Might need to add more? Also, the actual Asset Identifier definitions are in ZIP 227, and this just links to there. Not sure we should keep the rationale here?
PaulLaux
pushed a commit
that referenced
this pull request
Oct 4, 2023
This rearranges and rewrites various sections of the ZIP to make it more in line with the suggestions in ZIP 0. It also updates the Split Notes, Circuit Statement and Burn Mechanism sections with more information.
vivek-arte
added a commit
that referenced
this pull request
Feb 12, 2024
This rearranges and rewrites various sections of the ZIP to make it more in line with the suggestions in ZIP 0. It also updates the Split Notes, Circuit Statement and Burn Mechanism sections with more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rearranges and rewrites various sections of the ZIP to make it more in line with the suggestions in ZIP 0.