Closed
Conversation
dmidem
added a commit
that referenced
this pull request
Jul 29, 2024
* Add NoteBytes * Implement concat manually for wasm * Fix slice bounds in concat * Fmt * Split interface and implementation of NoteBytes * Add new method to NoteBytes --------- Co-authored-by: alexeykoren <2365507+alexeykoren@users.noreply.github.com>
|
closed in favor of #10 |
dmidem
added a commit
that referenced
this pull request
Jul 30, 2024
) * Attempt to resolve review issues for zcash/pull/2 * NoteBytes moved to zcash_note_encryption (copy of #8) (#9) * Add NoteBytes * Implement concat manually for wasm * Fix slice bounds in concat * Fmt * Split interface and implementation of NoteBytes * Add new method to NoteBytes --------- Co-authored-by: alexeykoren <2365507+alexeykoren@users.noreply.github.com> * Resolve review issues for zcash/pull/2 (except returning references from ShieldedOutput methods) * Fix cargo doc issue * Fix based on feedback from PR #10 review * Make split_ciphertext_at_tag a method of ShieldedOutput with minor refactoring --------- Co-authored-by: Dmitry Demin <dmitry@qed-it.com> Co-authored-by: alexeykoren <2365507+alexeykoren@users.noreply.github.com>
ConstanceBeguier
pushed a commit
that referenced
this pull request
May 20, 2025
Document that the Sapling implementation is in the `sapling-crypto` crate, not `zcash_primitives`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoteBytes moved to zcash_note_encryption.
dmidem: This PR can be closed in favor of #9 (copy of this PR but with the destination branch changed to
zcah_pr_issuesinstead ofzsa1). PR #9 has already been merged.