Skip to content

Update CHANGELOG.md with changes for note plaintext size generalization#6

Merged
dmidem merged 2 commits intozsa1from
update-changelog
May 16, 2024
Merged

Update CHANGELOG.md with changes for note plaintext size generalization#6
dmidem merged 2 commits intozsa1from
update-changelog

Conversation

@dmidem
Copy link

@dmidem dmidem commented May 16, 2024

This PR updates the CHANGELOG.md to include the changes related to the note plaintext size generalization under the "Unreleased" section.

@dmidem dmidem requested a review from PaulLaux May 16, 2024 14:24
Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor adjustments.

CHANGELOG.md Outdated
`CompactNotePlaintextBytes`, and `CompactNoteCiphertextBytes` to `Domain`
trait.
- Updated function signatures to remove constants that are unknown at
compilation time.
Copy link

@PaulLaux PaulLaux May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Generalized the note plaintext size to support variable sizes by adding the abstract types `NotePlaintextBytes`, `NoteCiphertextBytes`, `CompactNotePlaintextBytes`, and `CompactNoteCiphertextBytes` to the `Domain` trait.
- Moved the specific constants into the `Domain` trait implementations.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@dmidem dmidem merged commit 1ca015a into zsa1 May 16, 2024
@dmidem dmidem deleted the update-changelog branch May 16, 2024 14:55
ConstanceBeguier pushed a commit that referenced this pull request May 20, 2025
Add generalization to support OrchardZSA and AssetBase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants