Avoid use of Vec in ZSA-compatible version of lib.rs#3
Merged
Conversation
PaulLaux
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current CI build for this
zcash_note_encryptioncrate is failing when attempting to merge ZSA-related changes made inlib.rs. This issue arises from the use ofVecgeneric defined in the standard library ("std"), while the crate is configured with the#![no_std]directive inlib.rs.Current solution
To address the CI build failure, a temporary solution has been implemented by modifying the GitHub Actions CI configuration (
ci.yml) to enable the "alloc" feature. Since "alloc" also contains the definition ofVecand can serve as a lightweight alternative to "std," this adjustment allows the CI to complete successfully.ci.yml:... run: cargo build --features=alloc --no-default-features --verbose --target ${{ matrix.target }} ...While this approach resolves the immediate CI issue, it introduces additional dependencies. This may not be optimal, especially for scenarios involving the usage of
zcash_note_encryptionin embedded solutions or on the browser side.Proposed slternative solution
An alternative solution is presented in this draft pull request, involving modifications to the
lib.rsfile to eliminate the use ofVec. It's important to note that this alternative solution requires corresponding adjustments in theorchard_zsacrate, which implements theDomaintrait fromzcash_note_encryption.