Refactoring the SighashInfo portion of the transaction#49
Merged
Conversation
…id inside TransactionBase
…nside TransactionBase
…o be defined in V5 and V6 classes
PaulLaux
previously approved these changes
Jan 19, 2026
PaulLaux
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the portions of the
TransactionBaseclass so that it does not need to use theversion_group_idto decide behaviour - the way it behaves is decided by redefinition of the added functions in the child classes (akaTransactionV5andTransactionV6).This refactor does not affect the generated test vectors.