Minor changes suggested in review (non-ZSA)#43
Merged
Conversation
vivek-arte
changed the title
vivek-arte
force-pushed
the
pr108_review_fixes_orchard
branch
from
af84d84 to
4c7054b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the spacing, comment and minor rearrangements suggested in zcash#108 (review).
Specifically, this PR makes the changes that are touching the non ZSA portions of the repository. Therefore the PR is to
master, and merging it in would reduce the diff between the ZSA work and upstream.