Add versioned signatures for Sapling transactions#34
Conversation
323fb14 to
da2f267
Compare
da2f267 to
8c2eab9
Compare
PaulLaux
left a comment
There was a problem hiding this comment.
also,
Please remove #TODO comment in Transaction_v6.py:
assert have_orchard_zsa or not have_issuance #TODO: VA: Combine this with the above?
| if hasSapling: | ||
| if hasSighashInfo: |
There was a problem hiding this comment.
I cannot combine both into one because the last line is into hasSapling loop but not into hasSigashInfo loop
| for desc in self.vSpendsSapling: # vSpendProofsSapling | ||
| ret += bytes(desc.proof) | ||
| for desc in self.vSpendsSapling: # vSpendAuthSigsSapling | ||
| if hasSighashInfo: |
There was a problem hiding this comment.
let's remove this param hasSighashInfo completly and replace with a runtime check for the class:
if isinstance(self, (TransactionV6)):There was a problem hiding this comment.
or tx.version_bytes() == NU7_TX_VERSION_BYTES: to be unified with below
PaulLaux
left a comment
There was a problem hiding this comment.
Are all test files regenerated? I don't see new files for Sapling
Only transaction V6 is updated. So, only orchard_zsa_digests is updated. |
Add
SighashInfo(version and associated data) toUpdate
sapling_auth_digestby addingSighashInfoas defined in ZIP246