Skip to content

Update encodings for ik and issueAuthSig #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vivek-arte merged 15 commits into from
Sep 1, 2025
Merged

Update encodings for ik and issueAuthSig #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9f82d9a
updating test vectors for encoding change to ik and issueAuthSig
vivek-arte Jul 12, 2025
a2b7cd6
regenerating test vectors
vivek-arte Jul 12, 2025
3db688c
resolving review comments
vivek-arte Jul 18, 2025
4231a2a
resolving review comments, missed one change
vivek-arte Jul 18, 2025
852f591
renaming constant to ZSA_BIP340_SIG_SCHEME
vivek-arte Jul 25, 2025
fe4a66d
some further changes to specify the ik_encoding and issuer difference
vivek-arte Aug 25, 2025
2ebe36b
regenerating test vectors
vivek-arte Aug 25, 2025
44c5414
updating issuance_auth_sig.py to test for the encodings of the ik and…
vivek-arte Aug 29, 2025
8b25268
regenerated test vectors
vivek-arte Aug 29, 2025
6a2f3da
fixing allowed_choices to not have issuance without orchardzsa
vivek-arte Aug 29, 2025
b38ae64
adding asset_base extra checks for encode_asset_id
vivek-arte Aug 29, 2025
0875ce3
fixing generation of issue_auth_sig to be from SIGHASH_ALL instead of…
vivek-arte Aug 29, 2025
1ed9298
regenerating test vectors
vivek-arte Aug 29, 2025
aee8003
Update test_vectors.yml to try to fix CI issue
vivek-arte Aug 29, 2025
1c97af6
cosmetic improvements based on review (no changes to generated vectors)
vivek-arte Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test_vectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ jobs:
with:
python-version: '3.9'

- name: Update apt
run: sudo apt-get update

- name: Install gnome-keyring
run: sudo apt-get install gnome-keyring

Expand Down
40 changes: 20 additions & 20 deletions test-vectors/json/orchard_zsa_asset_base.json
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 8 additions & 10 deletions test-vectors/json/orchard_zsa_digests.json
View file
Open in desktop

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions test-vectors/json/orchard_zsa_issuance_auth_sig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
[
["From https://github.com/zcash-hackworks/zcash-test-vectors/blob/master/orchard_zsa_issuance_auth_sig.py"],
["isk, ik, msg, sig"],
["0000000000000000000000000000000000000000000000000000000000000003", "f9308a019258c31049344f85f89d5229b531c845836f99b08601f113bce036f9", "0000000000000000000000000000000000000000000000000000000000000000", "e907831f80848d1069a5371b402410364bdf1c5f8307b0084c55f1ce2dca821525f66a4a85ea8b71e482a74f382d2ce5ebeee8fdb2172f477df4900d310536c0"],
["5d7a8f739a2d9e945b0ce152a8049e294c4d6e66b164939daffa2ef6ee692148", "4bece1ff00e2ed7764ae6be20d2f672204fc86ccedd6fc1f71df02c7516d9f31", "1cdd86b3cc4318d9614fc820905d042bb1ef9ca3f24988c7b3534201cfb1cd8d", "a5b592781beb55eebf8bc2bfd79da9452dc92239877eb7e1f56465ff111e5908deac15d569999a2bd22b2ef601c5813bdbba993c08d4e856c926d9e2c0639367"],
["bf69b8250c18ef41294ca97993db546c1fe01f7e9c8e36d6a5e29d4e30a73594", "d4229e195e25f602a2186122cb4e78767b3c66ac390808d2d1b40442da7f0066", "bf5098421c69378af1e40f64e125946f62c2fa7b2fecbcb64b6968912a6381ce", "188b1557428783556b66803bf90663b7a16d4376927c5835e0b726520eb26d53249910c39c5f0590b6d6aab351ff8cd8e063fa74204255dadc00d9e0dff77b09"],
["3dc166d56a1d62f5a8d7551db5fd9313e8c7203d996af7d477083756d59af80d", "ceb75a439ff0161580bf295724c6d92d31b7aa02840339444964486faea890e5", "06a745f44ab023752cb5b406ed8985e18130ab33362697b0e4e4c763ccb8f676", "6e5ed6656c327132b16581062f1b138acc6f1f8343ed9d89ab5fd938e4e6cef799a2251ca52d60820e510025067dcd1bf754c5bff139b4cc44b37d27d17c4aee"],
["495c222f7fba1e31defa3d5a57efc2e1e9b01a035587d5fb1a38e01d94903d3c", "b0fa9d77fcbd96459132e305e324e7936ae13b15147e205d7bae42fa7faf5d1e", "3e0ad3360c1d3710acd20b183e31d49f25c9a138f49b1a537edcf04be34a9851", "17c2e5df2ea6a12e8ab2b0d504898f3f2343e098907f7afe43ac8a0114423580975367ba4b6d166c44284857b7cd29a838b49cc341d28951aa0b5d556a209eb6"],
["a7af9db6990ed83dd64af3597c04323ea51b0052ad8084a8b9da948d320dadd6", "0bb4913dbaf14ef6d0adeb8b7027bf0b9a8f590d3e2d95a12dbaaf0b9533dca4", "4f5431e61ddf658d24ae67c22c8d1309131fc00fe7f235734276d38d47f1e191", "421f5b07572e6b05e80ba585ff6321422675cd19ea5915d632eb47646ce220276bb78242cc7548d9a0572b89692e5b95db1414e4ebd220ccf83af2982fdd3aec"],
["e00c7a1d48af046827591e9733a97fa6b679f3dc601d008285edcbdae69ce8fc", "61bb339159df9820efaeb61d9a10cdc13b4c99fdc86d9485115dfd836236acf8", "1be4aac00ff2711ebd931de518856878f73476f21a482ec9378365c8f7393c94", "5a1148a8928fbf43bb33a570f0dfa35332b7018021a0cb75e9554e86ecb21da32eb5a2d8c59ea39043b97478750c6bf866eb3b015ebb3168f753766ad171d21e"],
["e2885315eb4671098b79535e790fe53e29fef2b3766697ac32b4f473f468a008", "1958538b1217a03d89cd83b83d0bdd40a69abe3ac25d00c6d26997f9f2574d4f", "e72389fc03880d780cb07fcfaabe3f1a84b27db59a4a153d882d2b2103596555", "1690f543ee67bb1ce0e4254ea5dfd042fe863ab46cd9a8905519ffb1b8406becbd90da66e5b544bcd43bdb29bc5d2c024dd285abcd77e4ac1f9d603522e4f15b"],
["ed9494c6ac893c49723833ec8926c1039586a7afcf4a0d9c731e985d99589c8b", "7dd6d761e1020137fa01b4ddd3b0f34804cc10cc4e9f6e9df5b60469f5793667", "b838e8aaf745533ed9e8ae3a1cd074a51a20da8aba18d1dbebbc862ded42435e", "59345d6b894ed6d03a5673a014630751043d11fa63187c929cae3fa1b02922f27dc0164033952c8416e6d0438177b3bce878fdec750a1664d489df0a4eaeb135"],
["92476930d069896cff30eb414f727b89e001afa2fb8dc3436d75a4a6f2657250", "b59c5f3234d6ca36cc483d67a84f37d6b24b24454825d2b7bfdc802b2e328c43", "4b192232ecb9f0c02411e52596bc5e90457e745939ffedbd12863ce71a02af11", "a458793326983774096d3659eb9a21d12c8eb877566b66bf6033db8fde20c466a2e95430a01eb9ad28e0765bed21dcd30386fce7aabadea6da728c16bb80f1c2"],
["7d417adb3d15cc54dcb1fce467500c6b8fb86b12b56da9c382857deecc40a98d", "45619f206c3bfc84fd424ffb5c816f654b27aa7f7b4bd67ec5f9ac6d0f38dbb1", "5f2935395ee4762dd21afdbb5d47fa9a6dd984d567db2857b927b7fae2db5871", "e6924d53ec978079d66a284c00a868f9eb751ae3b1690d15ee1b39680b83c438e45f02a23c656e4e53d3c73efa0dc5f7ad6328217fd59b23aae4f90c68be76bc"]
["isk, ik_encoding, msg, issue_auth_sig"],
["0000000000000000000000000000000000000000000000000000000000000003", "00f9308a019258c31049344f85f89d5229b531c845836f99b08601f113bce036f9", "0000000000000000000000000000000000000000000000000000000000000000", "00e907831f80848d1069a5371b402410364bdf1c5f8307b0084c55f1ce2dca821525f66a4a85ea8b71e482a74f382d2ce5ebeee8fdb2172f477df4900d310536c0"],
["5d7a8f739a2d9e945b0ce152a8049e294c4d6e66b164939daffa2ef6ee692148", "004bece1ff00e2ed7764ae6be20d2f672204fc86ccedd6fc1f71df02c7516d9f31", "1cdd86b3cc4318d9614fc820905d042bb1ef9ca3f24988c7b3534201cfb1cd8d", "00a5b592781beb55eebf8bc2bfd79da9452dc92239877eb7e1f56465ff111e5908deac15d569999a2bd22b2ef601c5813bdbba993c08d4e856c926d9e2c0639367"],
["bf69b8250c18ef41294ca97993db546c1fe01f7e9c8e36d6a5e29d4e30a73594", "00d4229e195e25f602a2186122cb4e78767b3c66ac390808d2d1b40442da7f0066", "bf5098421c69378af1e40f64e125946f62c2fa7b2fecbcb64b6968912a6381ce", "00188b1557428783556b66803bf90663b7a16d4376927c5835e0b726520eb26d53249910c39c5f0590b6d6aab351ff8cd8e063fa74204255dadc00d9e0dff77b09"],
["3dc166d56a1d62f5a8d7551db5fd9313e8c7203d996af7d477083756d59af80d", "00ceb75a439ff0161580bf295724c6d92d31b7aa02840339444964486faea890e5", "06a745f44ab023752cb5b406ed8985e18130ab33362697b0e4e4c763ccb8f676", "006e5ed6656c327132b16581062f1b138acc6f1f8343ed9d89ab5fd938e4e6cef799a2251ca52d60820e510025067dcd1bf754c5bff139b4cc44b37d27d17c4aee"],
["495c222f7fba1e31defa3d5a57efc2e1e9b01a035587d5fb1a38e01d94903d3c", "00b0fa9d77fcbd96459132e305e324e7936ae13b15147e205d7bae42fa7faf5d1e", "3e0ad3360c1d3710acd20b183e31d49f25c9a138f49b1a537edcf04be34a9851", "0017c2e5df2ea6a12e8ab2b0d504898f3f2343e098907f7afe43ac8a0114423580975367ba4b6d166c44284857b7cd29a838b49cc341d28951aa0b5d556a209eb6"],
["a7af9db6990ed83dd64af3597c04323ea51b0052ad8084a8b9da948d320dadd6", "000bb4913dbaf14ef6d0adeb8b7027bf0b9a8f590d3e2d95a12dbaaf0b9533dca4", "4f5431e61ddf658d24ae67c22c8d1309131fc00fe7f235734276d38d47f1e191", "00421f5b07572e6b05e80ba585ff6321422675cd19ea5915d632eb47646ce220276bb78242cc7548d9a0572b89692e5b95db1414e4ebd220ccf83af2982fdd3aec"],
["e00c7a1d48af046827591e9733a97fa6b679f3dc601d008285edcbdae69ce8fc", "0061bb339159df9820efaeb61d9a10cdc13b4c99fdc86d9485115dfd836236acf8", "1be4aac00ff2711ebd931de518856878f73476f21a482ec9378365c8f7393c94", "005a1148a8928fbf43bb33a570f0dfa35332b7018021a0cb75e9554e86ecb21da32eb5a2d8c59ea39043b97478750c6bf866eb3b015ebb3168f753766ad171d21e"],
["e2885315eb4671098b79535e790fe53e29fef2b3766697ac32b4f473f468a008", "001958538b1217a03d89cd83b83d0bdd40a69abe3ac25d00c6d26997f9f2574d4f", "e72389fc03880d780cb07fcfaabe3f1a84b27db59a4a153d882d2b2103596555", "001690f543ee67bb1ce0e4254ea5dfd042fe863ab46cd9a8905519ffb1b8406becbd90da66e5b544bcd43bdb29bc5d2c024dd285abcd77e4ac1f9d603522e4f15b"],
["ed9494c6ac893c49723833ec8926c1039586a7afcf4a0d9c731e985d99589c8b", "007dd6d761e1020137fa01b4ddd3b0f34804cc10cc4e9f6e9df5b60469f5793667", "b838e8aaf745533ed9e8ae3a1cd074a51a20da8aba18d1dbebbc862ded42435e", "0059345d6b894ed6d03a5673a014630751043d11fa63187c929cae3fa1b02922f27dc0164033952c8416e6d0438177b3bce878fdec750a1664d489df0a4eaeb135"],
["92476930d069896cff30eb414f727b89e001afa2fb8dc3436d75a4a6f2657250", "00b59c5f3234d6ca36cc483d67a84f37d6b24b24454825d2b7bfdc802b2e328c43", "4b192232ecb9f0c02411e52596bc5e90457e745939ffedbd12863ce71a02af11", "00a458793326983774096d3659eb9a21d12c8eb877566b66bf6033db8fde20c466a2e95430a01eb9ad28e0765bed21dcd30386fce7aabadea6da728c16bb80f1c2"],
["7d417adb3d15cc54dcb1fce467500c6b8fb86b12b56da9c382857deecc40a98d", "0045619f206c3bfc84fd424ffb5c816f654b27aa7f7b4bd67ec5f9ac6d0f38dbb1", "5f2935395ee4762dd21afdbb5d47fa9a6dd984d567db2857b927b7fae2db5871", "00e6924d53ec978079d66a284c00a868f9eb751ae3b1690d15ee1b39680b83c438e45f02a23c656e4e53d3c73efa0dc5f7ad6328217fd59b23aae4f90c68be76bc"]
]
Loading