Skip to content

Making suggested changes#16

Merged
vivek-arte merged 6 commits into
zsa1from
adding_changes_suggested
Jun 10, 2024
Merged

Making suggested changes#16
vivek-arte merged 6 commits into
zsa1from
adding_changes_suggested

Conversation

@vivek-arte
Copy link
Copy Markdown

This PR adds changes suggested by ECC for merging the ZSA changes into the zcash-test-vectors repository

  • It changes the comment on the addition of the BIP 340 reference to mention the specific commit the code has been copied from.
  • It adds back the generation of orchard_key_components, so that keys can be generated for orchard irrespective.

@vivek-arte vivek-arte force-pushed the adding_changes_suggested branch from af45f6b to b33d226 Compare May 20, 2024 13:10
PaulLaux
PaulLaux previously approved these changes Jun 4, 2024
Copy link
Copy Markdown

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor change req.

Comment thread zcash_test_vectors/orchard/key_components.py
Comment thread zcash_test_vectors/orchard_zsa/key_components.py Outdated
@vivek-arte vivek-arte merged commit 8a05f97 into zsa1 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants