Closed
Conversation
Collaborator
Author
|
NoteBytes are copied from Orchard to avoid dependency or extracting micro-crate |
PaulLaux
reviewed
Jul 17, 2024
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Some comments, not for immediate execution.
Cargo.toml
Outdated
| harness = false | ||
|
|
||
| [patch.crates-io] | ||
| zcash_note_encryption = { version = "0.4", git = "https://github.com/QED-it/zcash_note_encryption", branch = "zsa1" } No newline at end of file |
src/note_encryption.rs
Outdated
| try_sapling_output_recovery_with_ock, CompactOutputDescription, SaplingDomain, | ||
| Zip212Enforcement, | ||
| }; | ||
| use super::{prf_ock, sapling_note_encryption, try_sapling_compact_note_decryption, try_sapling_note_decryption, try_sapling_output_recovery, try_sapling_output_recovery_with_ock, CompactOutputDescription, SaplingDomain, Zip212Enforcement, NOTE_PLAINTEXT_SIZE, ENC_CIPHERTEXT_SIZE}; |
src/note_bytes.rs
Outdated
| /// Defines the behavior for types that support both read and write access to their internal byte array. | ||
| pub trait NoteByteWriter: NoteByteReader + AsMut<[u8]> {} | ||
|
|
||
| impl<const N: usize> NoteByteWriter for NoteBytes<N> {} |
There was a problem hiding this comment.
This entire file should move to zcash_note_encryption and reused here and in Orchard.
Collaborator
Author
There was a problem hiding this comment.
There are few PRs now created around that
|
closed in favor of #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constants have been moved from zcash_note_encryption
New components are implemented for SaplingDomain
dmidem: This PR can be closed in favor of #2 as #2 uses the changes from this PR and makes additional modifications to sync with the latest updates in
zcash_note_encryption.