Draft PR: Batch Validators and related changes#83
Closed
Conversation
…t_partial_ord_impl_on_ord_type clippy error
…undle-in-v5-vector-serialization-with-burn-valid branch
Changes Made: - Updated Rust version to 1.65 in Cargo.toml and other relevant configuration files. - Removed pins for dependencies that were previously locked to older Rust versions. - Updated CI configuration to use Rust 1.65.
This reverts commit 9b0839b.
PaulLaux
reviewed
Sep 26, 2023
|
|
||
| impl Eq for IssuanceValidatingKey {} | ||
|
|
||
| impl DynamicUsage for IssuanceValidatingKey { |
Closed
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft pull request (PR) encompasses all changes from the
ivk-to-bytes-visibility-downgrade-with-burn-validbranch, which has its own PR to zsa1 (#81). But additionally, it contains changes related to BatchValidators, which were initially implemented but later reverted in theivk-to-bytes-visibility-downgrade-with-burn-validbranch. Batch Validators are not currently used in the project, so this PR actually preserves the work for future reference and potential reintegration if needed. The PR is marked as a draft to indicate that it's not ready for merging.Changes Included:
Fix Orchard bundle BatchValidator:
OrchardbundleBatchValidatorby adding a call to thevalidate_bundle_burnfunction from thevalidatefunction.Add BatchValidator for Issue bundle:
BatchValidatorforIssueBundle, which includes a call to theverify_issue_bundlefunction from thevalidatefunction.