Closed
Conversation
ConstanceBeguier
changed the title
ConstanceBeguier
changed the title
PaulLaux
reviewed
Apr 17, 2023
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Looks good, some minor improvements are required.
| use subtle::CtOption; | ||
|
|
||
| #[test] | ||
| fn test_note_commit() { |
Collaborator
There was a problem hiding this comment.
This test does not test the derive() function - we need a native and non native tests for this function.
You can keep this test but please describe what is being tested here.
| if asset.is_native().into() { | ||
| // Commit to ZEC notes as per the Orchard protocol. | ||
| Self::commit(NOTE_COMMITMENT_PERSONALIZATION, zec_note_bits, rcm) | ||
| CtOption::<pallas::Point>::from(zec_hash_point) |
Collaborator
There was a problem hiding this comment.
can return the comments to emphasis the changes between the cases.
Collaborator
Author
|
Deprecated in favor of #54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to have a constant-time evaluation of the note commitment for both ZEC and ZSA.
ZEC_note_commitment=Extract_P(SinsemillaHashToPoint(zec_personalization, common_bits) + [rcm]R_zec)
ZSA_note_commitment=Extract_P(SinsemillaHashToPoint(zsa_personalization, common_bits || asset) + [rcm]R_zsa)