Skip to content

Create dummy spend in empty builder by default #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeykoren merged 1 commit into from
Dec 18, 2022
Merged

Create dummy spend in empty builder by default #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ impl Builder {

// Pair up the spends and recipients, extending with dummy values as necessary.
for (asset, (mut spends, mut recipients)) in
partition_by_asset(&self.spends, &self.recipients)
partition_by_asset(&self.spends, &self.recipients, &mut rng)
{
let num_spends = spends.len();
let num_recipients = recipients.len();
Expand Down Expand Up @@ -475,10 +475,12 @@ impl Builder {
}
}

/// partition a list of spends and recipients by note types.
/// Partition a list of spends and recipients by note types.
/// Method creates single dummy ZEC note if spends and recipients are both empty.
fn partition_by_asset(
spends: &[SpendInfo],
recipients: &[RecipientInfo],
rng: &mut impl RngCore,
) -> HashMap<AssetId, (Vec<SpendInfo>, Vec<RecipientInfo>)> {
let mut hm = HashMap::new();

Expand All @@ -496,6 +498,11 @@ fn partition_by_asset(
.push(r.clone())
}

if hm.is_empty() {
let dummy_spend = SpendInfo::dummy(AssetId::native(), rng);
hm.insert(dummy_spend.note.asset(), (vec![dummy_spend], vec![]));
}

hm
}

Expand Down