PR471 review: Address Str4d’s feedback from Jan 20, 2026 meeting#237
Merged
Conversation
Create a pub(crate) ValueSum::from_raw_inner function Put ValueSum::from_raw function behind the temprary-zebra feature flag
From sighash_info_for_kind: impl Fn(&OrchardSighashKind) -> &'static [u8] to sighash_info_for_kind: impl Fn(&OrchardSighashKind) -> Vec<u8>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
impl Add for NoteValuewith a dedicated helper functionUpdate
ValueSum::from_rawpub(crate) ValueSum::from_raw_innerhelperValueSum::from_rawbehind thetemporary-zebrafeature flagUpdate the
sighash_info_for_kindclosure used when evaluating digests&'static [u8]toVec<u8>