PR471 review: various fixes (2)#208
Merged
Merged
Conversation
r2585521988 r2585536670 r2585544143 r2585546655 r2585548116 r2585631816 r2585636883 r2599516192 r2599562825 r2599565711 r2599584010 r2599589396 r2599594554 r2599594936 r2599745324 r2602373392 r2602378140 r2602410770 r2602415043 r2602416292 r2602418341 r2602421894 r2602426619 r2602532807 r2602541601 r2602556915 r2602570477 (see note r2602938883 (see note) Note: r2602570477 and r2602938883 — we renamed the generic parameter P to Pr only where it conflicts with P for Proof. Should we use Pr for OrchardPrimitives everywhere else for consistency?
…ld and build_for_pczt methods
…t to build and build_for_pczt methods" This reverts commit 17de30c.
Inside ActionInfo::build_for_pczt, we check that - spend asset is equal to the native asset in self.spend.into_pczt(...) - output asset is equal to the native asset in self.output.into_pczt(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following review comments:
r2585521988
r2585536670
r2585544143
r2585546655
r2585548116
r2585631816
r2585636883
r2599516192
r2599562825
r2599565711
r2599584010
r2599589396
r2599594554
r2599594936
r2599745324
r2602373392
r2602378140
r2602410770
r2602415043
r2602416292
r2602421894
r2602426619
r2602532807
r2602541601
r2602556915
r2602570477 (see note)
r2602938883 (see note)
r2602418341
Note: r2602570477 and r2602938883 — we renamed the generic parameter P to Pr for OrchardPrimitives everywhere for consistency