PR471 review: various fixes (1)#207
Merged
Merged
Conversation
r2487851383 r2487857002 r2487858123 r2487968253 r2487968899 r2542305679 r2542313926 r2542359143 r2542360991 r2542333126 r2542371427 (see note) r2542392826 (see note) r2542406328 r2542447228 r2542428312 r2542599948 r2542671834 r2542817988 r2542846302 r2542756837 r2543147318 r2543502871 r2543506591 r2543527521 r2543542313 (see note) r2543565714 (see note) r2549938764 r2542276487 r2542288774 r2550151848 r2550187398 r2550276814 r2550352041 r2550380193 r2550407188 r2550616659 Note: r2542371427 is only partially addressed: issuance-related modules were moved under crate::issuance::*, but the zsa-issuance feature has not been added to Cargo.toml yet, and issuance code is not yet gated behind cfg(feature = "zsa-issuance"). The feature flag gating (and related optional dependency changes) will be handled in a follow-up PR. Note: r2542392826 addressed except orchard_flavor changes. Note: r2543542313 - changed pub to pub(crate) but needs to be discussed. Note: r2543565714 - It's not completely clear from the comment, but the doc comment for rseed_split_note has beed revomed in this commit and it has been updated it for create_split_note - is that correct? Also kept create_split_note pub, not pub(crate) - needs to be discussed.
Collaborator
ConstanceBeguier
left a comment
ConstanceBeguier
left a comment
There was a problem hiding this comment.
You can message me when you are available to discuss r2543542313 and r2543565714.
Co-authored-by: Constance Beguier <constance@qed-it.com>
Co-authored-by: Constance Beguier <constance@qed-it.com>
Co-authored-by: Constance Beguier <constance@qed-it.com>
Co-authored-by: Constance Beguier <constance@qed-it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the following review comments:
r2487851383
r2487857002
r2487858123
r2487968253
r2487968899
r2542305679
r2542359143
r2542360991
r2542333126
r2542371427 (see note)
r2542392826
r2542406328
r2542447228
r2542428312
r2542599948
r2542671834
r2542817988
r2542846302
r2542756837
r2543147318
r2543502871
r2543506591
r2543527521
r2543542313
r2543565714
r2549938764
r2542276487
r2542288774
r2550151848
r2550187398
r2550276814
r2550352041
r2550380193
r2550407188
r2550616659
r2542967008
Note: r2542371427 is only partially addressed: issuance-related modules were moved under crate::issuance::*, but the zsa-issuance feature has not been added to Cargo.toml yet, and issuance code is not yet gated behind cfg(feature = "zsa-issuance"). The feature flag gating (and related optional dependency changes) will be handled in a follow-up PR.