Skip to content

Upstream PR 471 (OrchardZSA) – internal review and fixes#201

Closed
dmidem wants to merge 153 commits into
zcash-ltf-zsafrom
zcash-pr471-review-fixes-1
Closed

Upstream PR 471 (OrchardZSA) – internal review and fixes#201
dmidem wants to merge 153 commits into
zcash-ltf-zsafrom
zcash-pr471-review-fixes-1

Address upstream PR #417 review comments (stage 2 - see details for l…

cd41b4f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Clippy Result (stable) succeeded Dec 22, 2025 in 16s

Clippy (Stable ~ Linux/x86_64)

Clippy was successful!

Details

Running cargo clippy took roughly ~16268ms to complete

  • Working Directory: repository directory

Annotations

Check warning on line 170 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L170

doc list item overindented
Raw output
warning: doc list item overindented
   --> src/issuance.rs:170:9
    |
170 |     ///    Pallas curve.
    |         ^^^ help: try using `  ` (2 spaces)
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/beta/index.html#doc_overindented_list_items
    = note: `#[warn(clippy::doc_overindented_list_items)]` on by default

Check warning on line 145 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L145

unused return value of `core::hash::Hasher::finish` that must be used
Raw output
warning: unused return value of `core::hash::Hasher::finish` that must be used
   --> src/note/asset_base.rs:145:9
    |
145 |         h.finish();
    |         ^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
help: use `let _ = ...` to ignore the resulting value
    |
145 |         let _ = h.finish();
    |         +++++++