Upstream PR 471 (OrchardZSA) – internal review and fixes#200

Closed

dmidem wants to merge 156 commits into

zcash-ltf-zsafrom

zcash-pr471-review-fixes

Commits on Dec 6, 2022

Circleci project setup (#1)
PaulLaux
committed
issuer keys implementation (#5)

daniben31
authored and
PaulLaux
committed
Added NoteType to Notes (#2)
PaulLaux
committed
ZSA note encryption in Orchard crate (#3)

committed
Zsa builder (#4)
PaulLaux
committed
Issuance (#12)
PaulLaux
committed
E2E tests for issuance (#20)

alexeykoren
authored and
PaulLaux
committed
disabled split notes (#22)
PaulLaux
committed
Review fixes (#23)
PaulLaux
committed
Review fixes2 (#24)
PaulLaux
committed
verify_issue_bundle() cleanup (#25)
PaulLaux
committed

Commits on Dec 7, 2022

ZSA burn functionality (#35)
alexeykoren
authored

Commits on Dec 18, 2022

Create dummy spend in empty builder by default (#36)
alexeykoren
authored

Commits on Dec 20, 2022

AssetID test vectors (#34)
alexeykoren
authored

Commits on Dec 21, 2022

CI-Badge (#37)
PaulLaux
authored

Commits on Dec 23, 2022

Use different random nullifiers in dummy notes (#39)
alexeykoren
authored

Commits on Jan 31, 2023

V3 encryption (#38)
PaulLaux
authored

Commits on Feb 9, 2023

Minimal API changes for Issuance in Client (#43)
alexeykoren
authored

Commits on Feb 14, 2023

Circuit: Split_flag handling (#42)
ConstanceBeguier
authored

Commits on Mar 2, 2023

AssetBase spec update (#44)
PaulLaux
authored

Commits on Mar 20, 2023

Upgrade pprof version with a limited inferno version (#48)
ConstanceBeguier
authored

Commits on Apr 18, 2023

Making changes to the asset base derivation from the asset identifier (#49)
vivek-arte
authored

Commits on Apr 21, 2023

Circuit: Update value_commit_orchard to take into account asset (#50)
ConstanceBeguier
authored

Commits on Apr 25, 2023

Constant-time note commitment for ZEC and ZSA (#54)
ConstanceBeguier
authored

Commits on May 4, 2023

Add tracking for supply info inside verify_issue_bundle (#55)
dmidem
authored

Commits on May 10, 2023

Add getter method for Bundle.burn field (#58)
dmidem
authored

Commits on May 16, 2023

Commits on May 23, 2023

Circuit: Update note_commit to take into account asset (#56)
ConstanceBeguier
authored

Commits on May 25, 2023

Circuit: Use nf_old_pub to evaluate new note commitment (with rho_new = nf_old_pub) (#62)
ConstanceBeguier
authored

Commits on May 29, 2023

Commits on Jun 1, 2023

Circuit: Add tests for orchard circuit (#63)
ConstanceBeguier
authored

Commits on Jun 6, 2023

Commits on Jun 12, 2023

Fix IssueBundle and IssueAction structures (#70)
ConstanceBeguier
authored

Commits on Jun 13, 2023

Commits on Jun 19, 2023

Update code to refer to the upgraded version of librustzcash and reflect the corresponding changes
dmidem
committed

Commits on Jun 20, 2023

Fix issuance key derivation (#74)
ConstanceBeguier
authored

Commits on Jun 21, 2023

Preventing Asset Base from being the identity point on the Pallas curve (#71)

vivek-arte
and
PaulLaux
authored

Commits on Jun 29, 2023

Circuit: Add constraints (#77)
ConstanceBeguier
authored

Commits on Jul 24, 2023

Circuit: Fix balance violation (#78)
ConstanceBeguier
authored

Commits on Aug 31, 2023

Circuit: Add enable_zsa flag (#79)
ConstanceBeguier
authored

Commits on Oct 4, 2023

Enhance and cleanup ivk-to-bytes-visibility-downgrade branch (#81)

dmidem
and
PaulLaux
authored

Commits on Oct 16, 2023

Circuit: optimized short range check on 4 and 5 bits (#86)
ConstanceBeguier
authored

Commits on Oct 17, 2023

Circuit: remove mutiplexer chip (#90)
ConstanceBeguier
authored

Commits on Oct 18, 2023

Circuit: optimize ZEC/ZSA hash computations in note commitment (#87)
ConstanceBeguier
authored

Commits on Nov 1, 2023

Adopt Orchard ZSA for Zebra (introduce zcash_note_encryption_zsa alias, minor enhancements) (#89)
dmidem
authored

Commits on Nov 7, 2023

Rename `sk_iss` to `isk`, the `IssuanceKey` struct to `IssuanceAuthorizingKey`, and move to a two key structure (#92)
vivek-arte
authored

Commits on Dec 18, 2023

Circuit: move mux functionality into CondSwap chip (#94)
ConstanceBeguier
authored

Commits on Dec 22, 2023

Update zcash_note_encryption dependency reference (#95)
dmidem
authored

Commits on Jan 31, 2024

Changing the Issuance Authorization Signature to the BIP 340 Schnorr scheme (#93)
vivek-arte
authored

Commits on Apr 15, 2024

Merge branch 'zcash-0.8.0' into zsa1-with-zcash-0.8.0
dmidem
committed

Commits on Apr 24, 2024

Fix compilation errors after the merge (there're still several complilation errors in tests)
dmidem
committed

Commits on Apr 25, 2024

Commits on Apr 29, 2024

Fix Builder::bundle function to pass unit tests from tests folder correctly
dmidem
committed

Commits on May 1, 2024

Fix comments, rename DEFAULT_WITH(OUT)_ZSA to DEVAULT_VANILLA(ZSA)
dmidem
committed

Commits on May 2, 2024

1) Use Option instead of usize::MAX in builder::partition_by_asset function. 2) Refactor builder::bundle function (pre-action genetation), to split 'fold' into three parts
dmidem
committed

Commits on May 7, 2024

Commits on May 9, 2024

Commits on Jul 16, 2024

OrchardZSA backward compatability 0.8.0 (#104)

authored

Commits on Jul 31, 2024

Synchronize Orchard with updates from zcash_note_encryption for zcash PR #2 issues resolve (#111)
dmidem
authored

Commits on Aug 14, 2024

Update ShieldedOutput implementation to return reference from enc_ciphertext (#112)
dmidem
authored

Commits on Sep 19, 2024

Remove redundancy in vanilla/zsa circuits
ConstanceBeguier
authored

Commits on Oct 8, 2024

Updating test vectors (#114)
vivek-arte
authored

Commits on Oct 10, 2024

Remove ZSA dummy notes
ConstanceBeguier
authored

Commits on Oct 14, 2024

Changing the type of the asset description from String to Vec<u8> (#113)

vivek-arte
and
PaulLaux
authored

Commits on Oct 15, 2024

Provide compatibility with librustzcash/zcash_client_backend: derive Clone for CompactAction (#118)
dmidem
authored

Commits on Nov 13, 2024

Exclude non-native assets from value_balance (#120)
alexeykoren
authored

Commits on Nov 28, 2024

Simplify Unproven struct
ConstanceBeguier
authored

Commits on Dec 9, 2024

Update SIGHASH according to OrchardDomain
ConstanceBeguier
authored

Commits on Dec 12, 2024

Add Clone trait to auth-related structures (#125)
alexeykoren
authored

Commits on Dec 16, 2024

Unify unique AssetBase concept in IssueAction
ConstanceBeguier
authored

Commits on Dec 17, 2024

Add a reference note for each first issuance
ConstanceBeguier
authored

Commits on Dec 20, 2024

Simplify bundle build function return type (#129)
ConstanceBeguier
authored

Commits on Dec 25, 2024

Fix some links and typo (#127)
ConstanceBeguier
authored

Commits on Jan 6, 2025

Install libfontconfig1-dev to fix CI build on updated Ubuntu runner (#132)
dmidem
authored

Commits on Jan 8, 2025

Update AssetSuply and SupplyInfo (new) (#133)

authored

Commits on Jan 18, 2025

Update to orchard_auth_digest computation (#134)
vivek-arte
authored

Commits on Jan 23, 2025

Commits on Jan 28, 2025

Add NULLIFIER_L constant
ConstanceBeguier
authored

Commits on Feb 4, 2025

Refactor AssetSupply to AssetRecords and update issuance verification functions (#138)
dmidem
authored

Commits on Feb 6, 2025

Fix cargo clippy warnings in PR #138 (#140)
dmidem
authored

Commits on Mar 12, 2025

Merge PCZT into zsa1
ConstanceBeguier
committed

Commits on Mar 17, 2025

Extend Orchard protocol flavor derives (#144)
dmidem
authored

Commits on Apr 7, 2025

Commits on Apr 19, 2025

Reduced Circle CI and github CI runtime (#158)
PaulLaux
authored

Commits on Apr 22, 2025

Lock Sinsemilla version (#160)
ConstanceBeguier
authored

Commits on May 6, 2025

Commits on May 22, 2025

Use the last version of zcash_note_encryption (#165)
ConstanceBeguier
authored

Commits on Jul 1, 2025

Commits on Jul 8, 2025

Update zcash_note_encryption crate (#171)
ConstanceBeguier
authored

Commits on Jul 15, 2025

Commits on Jul 23, 2025

Commits on Jul 28, 2025

Commits on Jul 31, 2025

Simplify ZSA implementation (#178)
ConstanceBeguier
authored

Commits on Aug 5, 2025

Remove native_asset_base prop_compose function (#180)
ConstanceBeguier
authored

Commits on Aug 26, 2025

Add rho derivation check in verify_issue_bundle (#183)
ConstanceBeguier
authored

Commits on Sep 1, 2025

Commits on Sep 11, 2025

Update zcash_note_encryption (9f7e93) (#190)
ConstanceBeguier
authored

Commits on Sep 12, 2025

Fix issuance_digest, issuance_auth_digest and orchard_digest (#189)

ConstanceBeguier
and
vivek-arte
authored

Commits on Sep 22, 2025

Updates to property testing (#191)
vivek-arte
authored

Commits on Sep 23, 2025

Create OrchardSighashVersion and IssueSighashVersion enum (#192)
ConstanceBeguier
authored

Commits on Oct 1, 2025

Add spend_auth_sigs_auth_digest into orchard_auth_digest (#193)
ConstanceBeguier
authored

Commits on Oct 21, 2025

Shuffle actions in a Bundle (#194)
ConstanceBeguier
authored

Commits on Oct 28, 2025

Fix split note in PCZT (#195)
ConstanceBeguier
authored

Commits on Oct 29, 2025

Remove PCZT v2 (#196)
ConstanceBeguier
authored

Commits on Nov 3, 2025

Remove dev-only numeric-extension patterns mistakenly committed to .gitignore (#198)
dmidem
authored