Simplify ZSA implementation#178
Clippy (Stable ~ Linux/x86_64)
Clippy was successful!
Details
Running cargo clippy took roughly ~18471ms to complete
- Working Directory: repository directory
Annotations
Check warning on line 169 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L169
variables can be used directly in the `format!` string
Raw output
warning: variables can be used directly in the `format!` string
--> src/builder.rs:169:38
|
169 | Proof(e) => f.write_str(&format!("Could not create proof: {}", e)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
|
169 - Proof(e) => f.write_str(&format!("Could not create proof: {}", e)),
169 + Proof(e) => f.write_str(&format!("Could not create proof: {e}")),
|
Check warning on line 824 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L824
doc list item without indentation
Raw output
warning: doc list item without indentation
--> src/builder.rs:824:5
|
824 | /// this method adds dummy spends and outputs until the minimum number of actions is reached.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
824 | /// this method adds dummy spends and outputs until the minimum number of actions is reached.
| ++
Check warning on line 825 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L825
doc list item without indentation
Raw output
warning: doc list item without indentation
--> src/builder.rs:825:5
|
825 | /// Dummy spends and outputs are added before shuffling to ensure backward compatibility.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
825 | /// Dummy spends and outputs are added before shuffling to ensure backward compatibility.
| ++
Check warning on line 165 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L165
doc list item overindented
Raw output
warning: doc list item overindented
--> src/issuance.rs:165:9
|
165 | /// Pallas curve.
| ^^^ help: try using ` ` (2 spaces)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
= note: `#[warn(clippy::doc_overindented_list_items)]` on by default
Check warning on line 7 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L7
doc list item without indentation
Raw output
warning: doc list item without indentation
--> src/primitives.rs:7:5
|
7 | //! It includes functionality for handling both the standard "Vanilla" variation and the ZSA
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
7 | //! It includes functionality for handling both the standard "Vanilla" variation and the ZSA
| ++
Check warning on line 8 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L8
doc list item without indentation
Raw output
warning: doc list item without indentation
--> src/primitives.rs:8:5
|
8 | //! variation, with different implementations for each. The different implementations are
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
8 | //! variation, with different implementations for each. The different implementations are
| ++
Check warning on line 9 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L9
doc list item without indentation
Raw output
warning: doc list item without indentation
--> src/primitives.rs:9:5
|
9 | //! organized into separate submodules.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
9 | //! organized into separate submodules.
| ++
Check warning on line 139 in /home/runner/work/orchard/orchard/src/lib.rs
github-actions / Clippy Result (stable)
/home/runner/work/orchard/orchard/src/lib.rs#L139
unused return value of `core::hash::Hasher::finish` that must be used
Raw output
warning: unused return value of `core::hash::Hasher::finish` that must be used
--> src/note/asset_base.rs:139:9
|
139 | h.finish();
| ^^^^^^^^^^
|
= note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
|
139 | let _ = h.finish();
| +++++++