Merged
Conversation
f28a418 to
ab0818c
Compare
PaulLaux
reviewed
Jul 24, 2025
Collaborator
PaulLaux
left a comment
There was a problem hiding this comment.
I like it more then our previous naming.
To conclude:
- can we do somthing with the file
primitives.rs? remove or make it relevent - the file
domain.rsexposes functions belong to primitives. can we move it toprimitives.rsand remove the file? - folder
domainshould be renamed toPrimitives? (we can create a newDomainfolder inside the renamedPrimitives.) - the struct
#[derive(Debug, Clone)]
pub struct OrchardDomain<P: OrchardPrimitives> {
/// A parameter needed to generate the nullifier.
pub rho: Rho,
phantom: core::marker::PhantomData<P>,
}should be in zcash_note_encryption_domain.rs or domain.rs not in orchard_primitives.rs
- instead
orchard_primitives::{OrchardDomain, OrchardPrimitives},we should probable have:
orchard_primitives::{Domain::OrchardDomain, OrchardPrimitives},
consider it, it is inlide with the suggestion above.
97f4090 to
8a09a2c
Compare
Collaborator
Author
|
I removed primitives.rs file. |
PaulLaux
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.