Skip to content

[Circuit] Reduce diff with upstream - #172

Merged
ConstanceBeguier merged 2 commits into
clean_zsa_circuit_partfrom
simplify_circuit
Jul 15, 2025
Merged

[Circuit] Reduce diff with upstream#172
ConstanceBeguier merged 2 commits into
clean_zsa_circuit_partfrom
simplify_circuit

Reduce diff with upstream

cf11bcc
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Clippy Result (stable) succeeded Jul 10, 2025 in 19s

Clippy (Stable ~ Linux/x86_64)

Clippy was successful!

Details

Running cargo clippy took roughly ~18195ms to complete

  • Working Directory: repository directory

Annotations

Check warning on line 169 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L169

variables can be used directly in the `format!` string
Raw output
warning: variables can be used directly in the `format!` string
   --> src/builder.rs:169:38
    |
169 |             Proof(e) => f.write_str(&format!("Could not create proof: {}", e)),
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
    = note: `#[warn(clippy::uninlined_format_args)]` on by default
help: change this to
    |
169 -             Proof(e) => f.write_str(&format!("Could not create proof: {}", e)),
169 +             Proof(e) => f.write_str(&format!("Could not create proof: {e}")),
    |

Check warning on line 139 in /home/runner/work/orchard/orchard/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Result (stable)

/home/runner/work/orchard/orchard/src/lib.rs#L139

unused return value of `core::hash::Hasher::finish` that must be used
Raw output
warning: unused return value of `core::hash::Hasher::finish` that must be used
   --> src/note/asset_base.rs:139:9
    |
139 |         h.finish();
    |         ^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
139 |         let _ = h.finish();
    |         +++++++