Fix CI breakage by pinning proptest 1.2.0 and locking font-kit/half versions#169
Merged
Fix CI breakage by pinning proptest 1.2.0 and locking font-kit/half versions#169
Conversation
…c-links step" This reverts commit cde5e1a.
PaulLaux
approved these changes
Jul 1, 2025
dmidem
added a commit
that referenced
this pull request
Jul 23, 2025
### Background * Orchard’s CI has a `build-latest` job that deletes `Cargo.lock` before it builds, so it always picks the newest compatible crate versions. * Everything went well until **proptest 1.7** was released. The next CI run removed `Cargo.lock`; the resolver upgraded proptest to 1.7, which depends on **`rand` 0.9**. Orchard and its crypto deps still use **`rand` 0.8** interface, and the mixed `rand_core` versions broke the build. * PR #169 fixed Orchard by pinning **`proptest = 1.2.0`** (that was the version in the old lockfile, known to work). ### Why that pin now breaks Zebra * `zebra-chain` and `zebra-scan` declares **`proptest = "1.4"`**. With an older Orchard commit (no exact pin) all crates (including `orchard` and `librustzcash` crates) resolved to 1.4.x. * Updating Zebra to the new Orchard commit brings in **`=1.2.0`**, and Cargo can’t satisfy **both** `=1.2.0` and `^1.4.0`. ### What this PR changes * Pin proptest to **1.4.0** in Orchard *and* librustzcash: ```toml # Cargo.toml proptest = { version = "=1.4.0", optional = true } [dev-dependencies] proptest = "=1.4.0" ``` * Version 1.4.0 is still on `rand` 0.8, so no further code changes are needed in `orchardd` and it satisfies Zebra’s `1.4.0` constraint. ### A few summarization notes 1. **Why did `proptest = "1.0.0"` work and then fail?** The caret requirement means “any release ≥ 1.0.0 < 2.0.0”. Deleting `Cargo.lock` let Cargo upgrade to the newest 1.y.z (now 1.7), which brings in `rand` 0.9 and conflicts with the rest of the tree. 2. **Why list proptest in *both* `[dependencies]` and `[dev-dependencies]`?** - feature `test-dependencies` includes `proptest` and `proptest` must be an optional dependency; - `dev-dependencies` are not allowed to be optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
proptest ≥ 1.5 wraps
rand_core::RngCorein a new trait that also needsDerefMut;StdRnglacks that, so the crate failed to compile aftercargo update(E0277 / E0599).What changed