Add a reference note for each first issuance#124
Merged
ConstanceBeguier merged 12 commits intozsa1from Dec 17, 2024
Merged
Conversation
PaulLaux
reviewed
Dec 9, 2024
Collaborator
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Added questions and comments.
PaulLaux
approved these changes
Dec 16, 2024
src/issuance.rs
Outdated
Comment on lines
+468
to
+478
| /// Validation for reference note | ||
| /// | ||
| /// The following checks are performed: | ||
| /// - the note value of the reference note is equal to 0 | ||
| /// - the asset of the reference note is equal to the provided asset | ||
| /// - the recipient of the reference note is equal to the reference recipient | ||
| pub fn verify_reference_note(note: &Note, asset: AssetBase) { | ||
| assert_eq!(note.value(), NoteValue::from_raw(0)); | ||
| assert_eq!(note.asset(), asset); | ||
| assert_eq!(note.recipient(), ReferenceKeys::recipient()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Let's move it inside the test section. this code is not fit for real usage (no error handling)
Collaborator
Author
There was a problem hiding this comment.
I use this function in tests/zsa.rs. Thus I cannot move it into test section.
Otherwise, I will have to duplicate it.
Collaborator
Author
There was a problem hiding this comment.
I duplicate the function in order to be able to move it into test section.
I have no access to ReferenceKeys::recipient() into tests/zsa.rs. Thus, I derived it from the zero SpendingKey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an asset is issue for the first time, we create a reference note which is a note with a value equal to zero and a recipient address equal to the reference recipient address.