Merged
Conversation
ConstanceBeguier
force-pushed
the
remove_circuit_param
branch
from
0b76e19 to
0da1c2c
Compare
PaulLaux
reviewed
Nov 19, 2024
PaulLaux
reviewed
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to remove the generic circuit parameter from Unproven structure.
To do that, we create a Witnesses structure which contains the witnesses of the circuit but not the circuit type (OrchardZSA or OrchardVanilla).
Key changes:
- Updated
src/builder.rsto replaceCircuitwithWitnessesin several function signatures and type definitions.- Adjusted
src/circuit.rsto define and use the newWitnessesstructure instead ofCircuit.