Skip to content

OrchardZSA backward compatability 0.8.0 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmidem merged 113 commits into from
Jul 16, 2024
Merged

OrchardZSA backward compatability 0.8.0 #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
113 commits
Select commit Hold shift + click to select a range
8bee528
draft2
PaulLaux Jan 4, 2024
5f78e72
draft3
PaulLaux Jan 4, 2024
5221c29
draft4
PaulLaux Jan 4, 2024
e07fab9
draft5
PaulLaux Jan 4, 2024
ee0a07d
draft6
PaulLaux Jan 4, 2024
8d2d130
Generalize orchard_zsa for backward bompatibility with non-ZSA functi…
dmidem Jan 17, 2024
b177325
Minor changes in the doc comments
dmidem Jan 17, 2024
4900519
Add tests for note_encryption_v2
dmidem Jan 22, 2024
0a3d231
Rename V2 name suffixes to Vanilla, and V3 - to ZSA
dmidem Jan 24, 2024
f3ae948
Make the Circuit struct generic to support different Orchard variants…
dmidem Jan 29, 2024
fc64461
Continue Circuit generalization
dmidem Feb 6, 2024
c6f8936
Split circuit implementation into circuit_vanilla and circuit_zsa
dmidem Feb 12, 2024
ce46de0
Fix to support modified halo2
dmidem Feb 27, 2024
e5ab5d0
Add missed fields to fn print_action_circuit
dmidem Feb 27, 2024
a8dadc9
Pin half crate to 1.8.2 (to resolve MSRV conflict)
dmidem Feb 27, 2024
a8a72c2
Pin half crate to 1.8.2 for dev deps too (to resolve MSRV conflict)
dmidem Feb 27, 2024
120b090
Pin half crate to 2.2.1
dmidem Feb 27, 2024
5d5bbf1
Fix cargo clippy errors
dmidem Feb 27, 2024
97f55f9
Convert arb_... testing functions to methods of dummy generict struct…
dmidem Mar 4, 2024
90512c8
Make hash_bundle_txid_data function backwards compatible
dmidem Mar 4, 2024
416b496
Refactor note_encryption.rs:
dmidem Mar 12, 2024
a1e6cd6
Fix cargo clippy errors
dmidem Mar 12, 2024
8b28a0e
Minor fix (make action module pub)
dmidem Mar 12, 2024
fc20a5a
Make add_chip.rs a shared module between circuit_vanilla and circuit_…
dmidem Mar 15, 2024
1d68e0b
Introduce OrcharcCircuit trait to eliminate repetitive 'where crate::…
dmidem Mar 18, 2024
c820dae
Introdice NoteByteReader and NoteByteWriter traiots to use with NoteB…
dmidem Mar 19, 2024
088494a
note_encryption: extract Domain impl, OrchardDoimain and NoteBytes de…
dmidem Mar 19, 2024
46a222e
Use vec with a proper length for the concrete OrchardDomain to genera…
dmidem Mar 25, 2024
367c701
Use try_fold instead of fold when cargo clippy suggests it
dmidem Mar 25, 2024
dc97b7a
Rename domain_impl.rs in note_encryption to domain.rs
dmidem Mar 25, 2024
cc99400
Intriduce orchard_flavor module with OrchardVanilla and OrchardZSA st…
dmidem Mar 25, 2024
e2306e3
Fix naming (OrchardDomainContex to OrchardDomainBase, Curcuit to Orch…
dmidem Mar 28, 2024
d721463
Fix 'half' dep duplication in Cargo.toml
dmidem Apr 9, 2024
6ba0a38
Remove rng from AssetBase::random call
dmidem Apr 9, 2024
19dbd0a
Minor change (improive use::crate::...)
dmidem Apr 15, 2024
b6d577e
Add hashing of burn field to hash_bundle_txid_data
dmidem Apr 15, 2024
8795ca4
Revert "Add hashing of burn field to hash_bundle_txid_data"
dmidem Apr 15, 2024
58e05b1
Adapt Orchard to changes in zcash_note_encryption dependency, which n…
dmidem Apr 17, 2024
e67c792
Revert "Revert "Add hashing of burn field to hash_bundle_txid_data""
dmidem Apr 17, 2024
a9af64c
Updating test vectors to correspond to those generated by the zcash-t…
vivek-arte Apr 30, 2024
511caf6
Merge branch 'zsa1' into orchardzsa-backward-compatability-0.8.0
dmidem May 13, 2024
019cbc4
Fix zcash_note_encryption dep name (to zcash_note_encryption_zsa)
dmidem May 13, 2024
8676e26
Fix merge conflict in the bench code
dmidem May 13, 2024
c99c043
FIx compilation issues for fake_compact_action function
dmidem May 13, 2024
b883997
Change type visibility
alexeykoren Apr 17, 2024
5ea48b4
Add map_proof method
alexeykoren Apr 19, 2024
7bed5a9
Add error types for burning
alexeykoren Apr 19, 2024
fb9e09a
Address PR #100 review notes (some issues remain unresolved)
dmidem May 20, 2024
12f77f7
Fix files missed in the previous commit
dmidem May 20, 2024
f27b3ce
Remove unnecessary comment
dmidem May 20, 2024
e2abb42
Make domain public
alexeykoren May 20, 2024
da51ae2
Update/add documentation to note_encryption and circuit related modules
dmidem May 29, 2024
5dac03e
Generate a real random encrypted note in action testing
dmidem May 30, 2024
450f814
Merge branch 'orchardzsa-backward-compatability-0.8.0' into orchardzs…
alexeykoren Jun 3, 2024
efe7b38
Remove unnecessary whitespace
alexeykoren Jun 3, 2024
56c850a
Pass None instead of OutgoingViewingKey for note encryption in arb_un…
dmidem Jun 3, 2024
93645de
Shorten comments for ...Arb generics in testing
dmidem Jun 3, 2024
e10efb3
Small fixes for Orchard/ZSA backward compatability in Librustzcash (#…
dmidem Jun 3, 2024
2273de6
Remove redundant note_encryption_v3.rs
dmidem Jun 6, 2024
6353684
Add missing benches and tests for Orchard Vanilla
dmidem Jun 9, 2024
4fa556d
Partially addressed review feedback on PR #104
dmidem Jun 10, 2024
6ffb37b
Add auth mapping
alexeykoren Jun 10, 2024
8c5274d
Simplify map authorization
alexeykoren Jun 10, 2024
f7789bf
Simplify map authorization
alexeykoren Jun 10, 2024
cb0d205
Rename CircuitBase to Circuit, test_encoding_roundtrip to encoding_ro…
dmidem Jun 11, 2024
fe8b986
Restore circuit_proof_test_case.bin in src
dmidem Jun 11, 2024
9df82ad
Remove circuit_proof_test_case_zsa.bin
dmidem Jun 11, 2024
e9e65bc
Move circuit_proof_test_case.bin to circuit/circuit_proof_test_case_z…
dmidem Jun 11, 2024
576f4c4
Rename note_encryption_vanilla/note_encryption_zsa to orchard_domain_…
dmidem Jun 11, 2024
f04c205
Fix comment for rho field of OrchardDomaiBase struct
dmidem Jun 11, 2024
3cd8294
Map authorization for IssueAuth (#108)
dmidem Jun 13, 2024
9a0cdab
Rename note_encryption/acion.rs to compact_action.rs
dmidem Jun 14, 2024
4a23e66
Restructure note encryption code: move note_encryption.rs functionali…
dmidem Jun 17, 2024
8289354
Minor fix in doc comment
dmidem Jun 17, 2024
b4dec8d
Update to use backward compatible version of halo2
dmidem Jun 20, 2024
3bf500f
Add missed file for the previous commit
dmidem Jun 20, 2024
3ccee39
Restore zsa1 version of note_encryption_v3.rs and remove note_encrypt…
dmidem Jun 20, 2024
a3aac82
Move note_encryption_v3.rs to domain.rs
dmidem Jun 20, 2024
6295375
Restore changes in domain.rs
dmidem Jun 20, 2024
621a5b4
Restore zsa1 version of note_encryption_v3.rs and remove note_encrypt…
dmidem Jun 20, 2024
fdfa5dc
Move note_encryption_v3.rs to domain.rs
dmidem Jun 20, 2024
1be9604
Restore changes in domain.rs
dmidem Jun 20, 2024
1dd1a82
Rename OrchardDomain to OrchardNoteEnc, OrchardDomainBase to OrchardD…
dmidem Jun 24, 2024
cfc2ddd
Fix cargo fmt issues
dmidem Jun 24, 2024
f4ae7f2
Use PallasLookupRCConfig in circuit_vanilla/note_commit.rs
dmidem Jun 24, 2024
f677ee2
Rename halo2 types
dmidem Jul 1, 2024
e2e200d
Rename OrchardNoteEnc to OrchardDomainCommon
dmidem Jul 1, 2024
b797abc
Use OrchardFlavor instead of OrchardDomainCommon+OrchardCircuit+Orcha…
dmidem Jul 1, 2024
1363d47
Fox cargo fmt issues
dmidem Jul 1, 2024
c05d06e
Fix generic arg name compilation error in benches
dmidem Jul 1, 2024
1de980f
Fix halo2 Sinsemilla amd Merke type chip names (remove ...WithPrivate…
dmidem Jul 1, 2024
4155972
Generalize test in commit_ivk to test against both Vanilla and ZSA ci…
dmidem Jul 1, 2024
060bf95
Generalize builder::tests::shielding_bundle to run it against both Va…
dmidem Jul 2, 2024
562dcf0
Remove unnecessary FIXMEs
dmidem Jul 2, 2024
27c03b4
Refactor burn items to use NoteValue
dmidem Jul 2, 2024
aa46d52
Use associated boolean const in MyLookup trait of commit_ivk test ins…
dmidem Jul 3, 2024
1bffe59
Add test case to ensure spend adding fails when spends are disabled
dmidem Jul 3, 2024
752feb1
Address the latest PR #104 review comments
dmidem Jul 5, 2024
f45db57
Add UnauthorizedBundleWithMetadata type alias to get rid of clippy wa…
dmidem Jul 5, 2024
b7b780c
Return doc comment for ActionArb in action.rs and removed unused impo…
dmidem Jul 5, 2024
82e19da
Lock halo2 dependencies to specific commit hash
dmidem Jul 8, 2024
1e54e19
Fix issues in bundle auth data commitment and note digest generation
dmidem Jul 8, 2024
3efb12c
Return BuildError (BurnDuplicateAsset) in add_burn for duplicate asse…
dmidem Jul 8, 2024
80c7574
Modify bundle::try_map_value_balance fn to convert only value_balance…
dmidem Jul 8, 2024
b72152a
Parameterized benchmark group labels with flavor names in note_encryp…
dmidem Jul 8, 2024
0c3742a
Fix 'cargo clippy --tests' warnings
dmidem Jul 11, 2024
be1fc32
Fix panic in "compact-note-decryption/invalid" check for ZSA and Vani…
dmidem Jul 12, 2024
f0c40f2
Make OrchardDomainCommon pub
dmidem Jul 15, 2024
c4baaa7
Make from_bytes/to_bytes methods of NoteValue pub (needed for librust…
dmidem Jul 15, 2024
2d7e2a3
Minor fix of comments
dmidem Jul 15, 2024
de85554
Minor update in FIXME
dmidem Jul 15, 2024
b20ff2f
Removed extra FIXMEs
dmidem Jul 15, 2024
4aff14d
Restore parse_note_version function and remove NOTE_VERSION_BYTE asso…
dmidem Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@
.vscode
.idea
action-circuit-layout.png
*.[0-9]
*.[0-9][0-9]
Loading