Add Regtest network#77
Merged
Merged
Conversation
PaulLaux
approved these changes
Nov 5, 2024
Collaborator
PaulLaux
left a comment
There was a problem hiding this comment.
approved with one comment
| } | ||
| } | ||
|
|
||
| #[derive(PartialEq, Eq, Copy, Clone, Debug)] |
Collaborator
There was a problem hiding this comment.
should probably keep hash here and in pub struct RegtestNetwork;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Add Regtest network
PR Type
enhancement
Description
RegtestNetworkstruct to support the regtest network.Parameterstrait forRegtestNetwork, defining its network type and activation heights.RegtestNetworkto theNetworkenum and updated theParametersimplementation to handle it.Changes walkthrough 📝
consensus.rs
Add support for Regtest network in consensus modulecomponents/zcash_protocol/src/consensus.rs
RegtestNetworkstruct and implemented theParameterstraitfor it.
REGTEST_NETWORKfor the regtest network.Networkenum to includeRegtestNetwork.Parametersimplementation forNetworkto handleRegtestNetwork.