Updated test vectors

zcash_primitives/src/transaction/components/issuance.rs

@@ -50,7 +50,9 @@ fn read_authorization<R: Read>(mut reader: R) -> io::Result<Signed> {
 
 fn read_action<R: Read>(mut reader: R) -> io::Result<IssueAction> {
     let asset_descr_bytes = Vector::read(&mut reader, |r| r.read_u8())?;
-    let asset_descr: String = asset_descr_bytes.iter().map(|&b| b as char).collect();
+    //TODO: Properly handle non-valid UTF-8 encodings.
+    let asset_descr: String = String::from_utf8(asset_descr_bytes)
+        .map_err(|_| Error::new(ErrorKind::InvalidData, "Asset Description not valid UTF-8"))?;
     let notes = Vector::read(&mut reader, |r| read_note(r))?;
     let finalize = reader.read_u8()? != 0;
     Ok(IssueAction::from_parts(asset_descr, notes, finalize))

zcash_primitives/src/transaction/tests.rs

@@ -231,6 +231,7 @@ impl Authorization for TestUnauthorized {
     type TzeAuth = tze::Authorized;
 }
 
+mod data_v6;
 #[test]
 fn zip_0244() {
     fn to_test_txdata(
@@ -313,7 +314,12 @@ fn zip_0244() {
         (tdata, txdata.digest(TxIdDigester))
     }
 
-    for tv in self::data::zip_0244::make_test_vectors() {
+    #[allow(unused_mut)] // mutability required for the V6 case which is flagged off by default
+    let mut test_vectors = self::data::zip_0244::make_test_vectors();
+    #[cfg(zcash_unstable = "nu6" /* TODO nu7 */ )]
+    test_vectors.extend(data_v6::orchard_zsa_digests::make_test_vectors());
+
+    for tv in test_vectors {
         let (txdata, txid_parts) = to_test_txdata(&tv);
 
         if let Some(index) = tv.transparent_input {