Pin winnow and inferno dependencies to resolve version and compilation conflicts#29
Closed
Pin winnow and inferno dependencies to resolve version and compilation conflicts#29
Conversation
Collaborator
Author
|
These fixes resolve the problem with It logs an error: It's possible that the UPDATE: It seems that the |
PaulLaux
approved these changes
May 11, 2023
Collaborator
PaulLaux
left a comment
There was a problem hiding this comment.
Done with small fixes to comments.
Collaborator
Author
|
Closing this in favor of PR #30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses build issues within the
librustzcashrepository.In the
zcash_historycrate, thewinnowdependency has been pinned to an older version. The latest version ofwinnowenforces the use of Rust v1.64.0, but thezcash_historycrate is tied to Rust v1.61.0. This mismatch was causing build problems, which have now been resolved by this change.The
infernodependency, which is used in thezcash_proofscrate among possibly others, has also been pinned to an older version. The latest version ofinferno(0.11.15) was causing a compilation error. By pinning it to version 0.11.14, this issue has been resolved.These changes are temporary fixes, and should be revisited once the Rust version used in the
librustzcashrepository is updated or the dependencies resolve their respective issues.