Skip to content

Pin winnow and inferno dependencies to resolve version and compilation conflicts#29

Closed
dmidem wants to merge 3 commits intozsa1from
pin_winnow_dep_to_v041
Closed

Pin winnow and inferno dependencies to resolve version and compilation conflicts#29
dmidem wants to merge 3 commits intozsa1from
pin_winnow_dep_to_v041

Conversation

@dmidem
Copy link
Copy Markdown
Collaborator

@dmidem dmidem commented May 9, 2023

This PR addresses build issues within the librustzcash repository.

In the zcash_history crate, the winnow dependency has been pinned to an older version. The latest version of winnow enforces the use of Rust v1.64.0, but the zcash_history crate is tied to Rust v1.61.0. This mismatch was causing build problems, which have now been resolved by this change.

The inferno dependency, which is used in the zcash_proofs crate among possibly others, has also been pinned to an older version. The latest version of inferno (0.11.15) was causing a compilation error. By pinning it to version 0.11.14, this issue has been resolved.

These changes are temporary fixes, and should be revisited once the Rust version used in the librustzcash repository is updated or the dependencies resolve their respective issues.

@dmidem dmidem requested a review from PaulLaux May 9, 2023 09:34
@dmidem dmidem changed the title Pin winnow dependency to older version due to required Rust version c… Pin winnow dependency in zcash_history to resolve Rust version conflict May 9, 2023
@dmidem
Copy link
Copy Markdown
Collaborator Author

dmidem commented May 9, 2023

These fixes resolve the problem with winnow and inferno, but there is another issue when CI checks the repo.

It logs an error: "Input required and not supplied: path" for actions/cache@v3.0.11 GitHub action, and here's a possible place in .github/workflows/ci.yml that causes the issue:

      - name: Cache Zcash parameters
        id: cache-params
        uses: actions/cache@v3.0.11
        with:
          path: ${{ env.ZCASH_PARAMS }}
          key: ${{ runner.os }}-params

It's possible that the ZCASH_PARAMS variable is not defined in the repo settings (environment).

UPDATE:

It seems that the "Input required and not supplied: path" error disappeared after I made fixes to resolve dependency issues. Therefore, it passes all CI checks now.

@dmidem dmidem changed the title Pin winnow dependency in zcash_history to resolve Rust version conflict Pin winnow and inferno dependencies to resolve version and compilation conflicts May 9, 2023
Copy link
Copy Markdown
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with small fixes to comments.

Comment thread zcash_proofs/Cargo.toml Outdated
Comment thread zcash_history/Cargo.toml Outdated
@dmidem
Copy link
Copy Markdown
Collaborator Author

dmidem commented Jun 18, 2023

Closing this in favor of PR #30

@dmidem dmidem closed this Jun 18, 2023
@dmidem dmidem deleted the pin_winnow_dep_to_v041 branch August 23, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants