Add NonIdentityPoint::new_from_constant#55
Merged
Conversation
PaulLaux
approved these changes
Apr 30, 2026
| point.map(|inner| NonIdentityPoint { chip, inner }) | ||
| } | ||
|
|
||
| /// Constructs a new point with the given value. |
There was a problem hiding this comment.
/// Witnesses the given constant point with both coordinates pinned via
/// fixed columns.
There was a problem hiding this comment.
/// Witnesses the given point with only on-curve / non-identity constraints.
/// For known-constant points use [`NonIdentityPoint::new_from_constant`];
Comment on lines
+80
to
+82
| /// Witnesses the given constant point as a private input to the circuit. | ||
| /// This returns an error if the point is the identity. | ||
| fn witness_point_non_id_from_constant( |
There was a problem hiding this comment.
/// Witnesses the given constant point with both coordinates pinned via
/// fixed columns. Returns an error if the point is the identity.
| .map(|(x, y)| NonIdentityEccPoint::from_coordinates_unchecked(x, y)) | ||
| } | ||
|
|
||
| /// Assigns a constant non-identity point. |
There was a problem hiding this comment.
/// Assigns a constant non-identity point with both coordinates pinned via
/// fixed columns.
ConstanceBeguier
force-pushed
the
non_identity_constant_point
branch
from
8ace9db to
46687fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
NonIdentityPoint::new_from_constantto enable creating non-identity points that are properly pinned to constants, which is required by the Orchard ZSA circuit (Orchard PR).More precisely, in the Orchard ZSA circuit,
q_init_zec/q_init_zsamust be constrained to fixed constants, as they define the initial pointQof the Sinsemilla hash. If constructed viaNonIdentityPoint::new, they remain unconstrained witnesses, allowing a prover to inject an arbitrary on-curve point and break commitment soundness.