Add functionalities for ZSA note commitment#15
Merged
ConstanceBeguier merged 3 commits intozsa1from May 4, 2023
Merged
Conversation
PaulLaux
approved these changes
May 4, 2023
ConstanceBeguier
force-pushed
the
circuit_note_commitment
branch
from
b64c665 to
0a091aa
Compare
Author
|
I rebased this branch on zsa1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following modifications are required to implement the ZSA note commitment in the circuit:
hashandblinding_factorfunctions to be able to evaluate separately the hash and the blinding factor of a commitmentfrom_coordinates_uncheckedpubliclyAssignedCell<F, F>into aAssignedCell<Assigned<F>, F>The last two items will be used in our MUX chip.