Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker configuration capabilities #99

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Add marker configuration capabilities #99

merged 5 commits into from
Dec 7, 2021

Conversation

alexsludds
Copy link
Contributor

For my work with M3202A modules in a 9010 chassis I need to use markers for precise timing of other equipment in the setup. This function allows me to generate marker signals from the trigger port.

For my work with M3202A modules in a 9010 chassis I need to use markers for precise timing of other equipment in the setup. This function allows me to generate marker signals from the trigger port.
alexsludds and others added 2 commits June 25, 2021 11:53
I'm sorry, I misunderstood what the result parser was doing. I have removed it. This code is running correctly on my hardware in the lab.
@FarBo
Copy link
Contributor

FarBo commented Jun 28, 2021

@alexsludds
We had a fix for doc building in the respoitory files, so I merged the master branch to have that fix for this PR. Now the CI passes

@alexsludds
Copy link
Contributor Author

Awesome! Can we merge this now?

@FarBo
Copy link
Contributor

FarBo commented Jul 1, 2021

@alexsludds
We have still an open conversation. in your function, you have 'verbose' argument that you are not using it after your recent change. This should be corrected before any merge :)

@astafan8 astafan8 enabled auto-merge December 7, 2021 10:24
@codecov-commenter
Copy link

Codecov Report

Merging #99 (77b7cab) into master (238f4f7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #99      +/-   ##
=========================================
- Coverage    6.92%   6.92%   -0.01%     
=========================================
  Files          97      97              
  Lines       12261   12264       +3     
=========================================
  Hits          849     849              
- Misses      11412   11415       +3     
Impacted Files Coverage Δ
...ntrib_drivers/drivers/Keysight/SD_common/SD_AWG.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238f4f7...77b7cab. Read the comment docs.

@astafan8 astafan8 merged commit a71565e into QCoDeS:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants