Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add driver for Lakeshore Model 625 #86

Merged
merged 19 commits into from
Feb 4, 2021
Merged

feat: add driver for Lakeshore Model 625 #86

merged 19 commits into from
Feb 4, 2021

Conversation

simonzihlmann
Copy link
Contributor

This pull request proposes a driver for the Lakeshore Model 625 superconducting magnet power supply as well as an example notebook.

@simonzihlmann
Copy link
Contributor Author

Please let me know why the checks failed and if some work needs to be done. I din't get the errors.

@jenshnielsen
Copy link
Collaborator

@simonzihlmann

There are two seperate issues.

  1. The CI is trying to execute your notebook. That cannot work since it does not have access to the instrument. You should disable execution as documented here https://qcodes.github.io/Qcodes/examples/writing_drivers/Creating-Instrument-Drivers.html#Documentation

  2. Is a typechecking issue. I will leave a comment inline explaining this

jenshnielsen
jenshnielsen reviewed Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonzihlmann Thanks for the contribution. I left a few minor comments inline

qcodes_contrib_drivers/drivers/Lakeshore/Model_625.py Outdated Show resolved Hide resolved
docs/examples/Lakeshore_625.ipynb Outdated Show resolved Hide resolved
qcodes_contrib_drivers/drivers/Lakeshore/Model_625.py Outdated Show resolved Hide resolved
qcodes_contrib_drivers/drivers/Lakeshore/Model_625.py Outdated Show resolved Hide resolved
@simonzihlmann
Copy link
Contributor Author

@jenshnielsen Do I miss anything? Let me know if there are still problems with the driver.

@jenshnielsen
Copy link
Collaborator

@simonzihlmann sorry for the delay. I think this looks good

@simonzihlmann
Copy link
Contributor Author

@simonzihlmann sorry for the delay. I think this looks good

nor worry

@jenshnielsen jenshnielsen merged commit 97e05f8 into QCoDeS:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonzihlmann @jenshnielsen @qubit-ref