Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini circuits modular test system #319

Merged
merged 7 commits into from
Apr 29, 2024

Conversation

FKMalina
Copy link
Contributor

Our system was recently equipped with Minicircuits modular test system (https://www.minicircuits.com/WebStore/ztm.html).
I created a new driver for the instrument, which reads out the modules installed in the system and makes an Instrument object with several InstrumentModules.
The driver was inspected by Mini-Circuits, but not reviewed.
The driver only includes the switch and amplifier modules, which are not of all available modules for the instruments. However, our device has only some of the possible modules, so I limited the driver to ones I could have tested explicitly, and the ones that are extremely similar.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FKMalina awesome, thank you for contributing! Would you need help with adressing typing errors (see CI)?

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 10.97%. Comparing base (02ba69d) to head (346bae3).

Files Patch % Lines
...qcodes_contrib_drivers/drivers/Minicircuits/ZTM.py 0.00% 78 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   11.02%   10.97%   -0.05%     
==========================================
  Files         131      132       +1     
  Lines       17462    17540      +78     
==========================================
  Hits         1925     1925              
- Misses      15537    15615      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FKMalina
Copy link
Contributor Author

I fixed typing error. LMK if there is something else needed to make the driver useful and easy to use!

@astafan8 astafan8 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into QCoDeS:main with commit 6bf75b3 Apr 29, 2024
10 of 12 checks passed
@FKMalina FKMalina deleted the Mini-Circuits-modular-test-system branch May 7, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants