Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tektronix FCA3100 counter driver #300

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

simonzihlmann
Copy link
Contributor

This implements a first version of a driver for the Tektronix FCA3100 counter.
Thanks to Axel Leblanc and Martin Endres for their work!

@jenshnielsen or @astafan8 could you please have a look?

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 11.46%. Comparing base (b372037) to head (bca31e9).

Files Patch % Lines
...codes_contrib_drivers/drivers/Tektronix/FCA3100.py 0.00% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   11.49%   11.46%   -0.04%     
==========================================
  Files         123      124       +1     
  Lines       16745    16790      +45     
==========================================
  Hits         1925     1925              
- Misses      14820    14865      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments! we can merge the PR once you respond. THank you for the contribution!

@astafan8 astafan8 changed the title first version of a driver for the Tektronix FCA3100 counter Tektronix FCA3100 counter driver Mar 4, 2024
@astafan8 astafan8 enabled auto-merge March 4, 2024 14:17
@astafan8 astafan8 added this pull request to the merge queue Mar 4, 2024
Merged via the queue into QCoDeS:main with commit 92bda46 Mar 4, 2024
10 of 12 checks passed
@simonzihlmann simonzihlmann deleted the feat_Tektronix_FCA3110 branch March 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants