Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers for Valon 5015 Frequency Synthesizer instrument #270

Merged
merged 9 commits into from
Nov 22, 2023

Conversation

fedonman
Copy link
Contributor

@fedonman fedonman commented Nov 15, 2023

This PR:

  • Adds the drivers/Valon/Valon_1505.py file which contains the driver for the Valon 5015 Frequency Synthesizer instrument.
  • Adds the docs/examples/Valon_1505.ipynb file which contains an example on how to use the driver.

Tests and sims are not implemented, but the driver has been tested manually in the lab.

Copy link

@AlbertMitjans AlbertMitjans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!! Can you add this driver in the __init__ of the drivers module? 🙏

@AlbertMitjans
Copy link

@astafan8 can you take a look at this PR? We would love to merge it this week 😄

@astafan8 astafan8 enabled auto-merge November 20, 2023 13:44
@fedonman
Copy link
Contributor Author

fedonman commented Nov 20, 2023

Hello @astafan8 and thanks for the approval. build docs action is failing with error ValueError: Could not locate a VISA implementation. Install either the IVI binary or pyvisa-py. I guess this has to do with the environment used in the action and not with the PR itself. But this error blocks the auto-merge feature, and there is no option for manual merging.

@astafan8
Copy link
Contributor

@fedonman ah, indeed. So one needs to disable the execution of the example notebook during the docs build, see here for instructions https://qcodes.github.io/Qcodes/examples/writing_drivers/Creating-Instrument-Drivers.html#Documentation

auto-merge was automatically disabled November 20, 2023 17:07

Head branch was pushed to by a user without write access

@fedonman
Copy link
Contributor Author

@fedonman ah, indeed. So one needs to disable the execution of the example notebook during the docs build, see here for instructions https://qcodes.github.io/Qcodes/examples/writing_drivers/Creating-Instrument-Drivers.html#Documentation

@astafan8 Done, thank you. Could you run the workflow again?

@fedonman
Copy link
Contributor Author

@astafan8 Hey, I think, GitHub doesn't like me and disabled the auto-merge 😆

auto-merge was automatically disabled 6 hours ago
Head branch was pushed to by a user without write access

If you feel everything is in place, be free to merge this. Thanks!

@astafan8 astafan8 merged commit a21faea into QCoDeS:main Nov 22, 2023
8 checks passed
@fedonman fedonman deleted the drivers/valon-5015 branch November 22, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants