-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drivers for Valon 5015 Frequency Synthesizer instrument #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!! Can you add this driver in the __init__
of the drivers module? 🙏
@astafan8 can you take a look at this PR? We would love to merge it this week 😄 |
Hello @astafan8 and thanks for the approval. |
@fedonman ah, indeed. So one needs to disable the execution of the example notebook during the docs build, see here for instructions https://qcodes.github.io/Qcodes/examples/writing_drivers/Creating-Instrument-Drivers.html#Documentation |
Head branch was pushed to by a user without write access
@astafan8 Done, thank you. Could you run the workflow again? |
@astafan8 Hey, I think, GitHub doesn't like me and disabled the auto-merge 😆
If you feel everything is in place, be free to merge this. Thanks! |
This PR:
drivers/Valon/Valon_1505.py
file which contains the driver for the Valon 5015 Frequency Synthesizer instrument.docs/examples/Valon_1505.ipynb
file which contains an example on how to use the driver.Tests and sims are not implemented, but the driver has been tested manually in the lab.