Add Thorlabs KLS1550 laser driver #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astafan8
approved these changes
Aug 23, 2023
|
@iago-rst thank you for the PR! Could you disable execution of the example notebook duing docs build? here are the isntructions on how to do that https://qcodes.github.io/Qcodes/examples/writing_drivers/Creating-Instrument-Drivers.html#Documentation . Then the PR will be merged! |
auto-merge was automatically disabled
August 23, 2023 12:57
Head branch was pushed to by a user without write access
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 20.60% 20.47% -0.14%
==========================================
Files 134 136 +2
Lines 16852 16966 +114
==========================================
Hits 3473 3473
- Misses 13379 13493 +114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request adds a wrapper class for Thorlabs Kinesis DLL and a driver for Thorlabs KLS1550 laser source using the DLL.
The existing Thorlabs APT wrapper did not seem to work with KLS1550 even though it should be supported for it (only driving the laser with the APT GUI worked, but not directly sending commands through the ATP DLL).