Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDAC1: Allow slopes greater than 10V #209

Merged
merged 4 commits into from
Apr 4, 2023
Merged

QDAC1: Allow slopes greater than 10V #209

merged 4 commits into from
Apr 4, 2023

Conversation

jpsecher
Copy link
Contributor

- Handle excess output
- Report errors in complex commands

    - Handle excess output
    - Report errors in complex commands
qcodes_contrib_drivers/drivers/QDevil/QDAC1.py Outdated Show resolved Hide resolved
@jpsecher
Copy link
Contributor Author

jpsecher commented Mar 20, 2023

Hmm, I just tried the same trick on the QDAC2 driver, and it did not work as expected, that is, the timeout was not overridden...

If that is the case, the patch will make the driver somewhat unusable.

@astafan8
Copy link
Contributor

@jpsecher

Hmm, I just tried the same trick on the QDAC2 driver, and it did not work as expected, that is, the timeout was not overridden...
If that is the case, the patch will make the driver somewhat unusable.

this is strange. note that the self.timeout parameter is in seconds, not in milliseconds (like self.visa_handle.timeout) - could that be the issue?

@jpsecher
Copy link
Contributor Author

Of course it is in seconds (https://www.youtube.com/watch?v=QfnC_3Uxj2I)

So the value has to be divided by thousand. I am not sure how to do it here in Github though...

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2023

Codecov Report

Merging #209 (d6732ec) into main (11a8456) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   20.64%   20.60%   -0.04%     
==========================================
  Files         134      134              
  Lines       16824    16852      +28     
==========================================
  Hits         3473     3473              
- Misses      13351    13379      +28     
Impacted Files Coverage Δ
qcodes_contrib_drivers/drivers/QDevil/QDAC1.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@astafan8 astafan8 enabled auto-merge April 3, 2023 08:35
@astafan8 astafan8 disabled auto-merge April 3, 2023 08:35
@astafan8
Copy link
Contributor

astafan8 commented Apr 3, 2023

@jpsecher i see that you managed to to change set_to to 0.001 - is everything working now? if so, let's merge?

@astafan8 astafan8 enabled auto-merge April 3, 2023 14:10
@astafan8
Copy link
Contributor

astafan8 commented Apr 4, 2023

@jpsecher could you merge the latest gratest main into your branch? then the Pr will be merged automatically

@astafan8 astafan8 merged commit 04cfd3d into QCoDeS:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants