-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QDAC1: Allow slopes greater than 10V #209
Conversation
jpsecher
commented
Mar 20, 2023
- Handle excess output - Report errors in complex commands
Co-authored-by: Mikhail Astafev <[email protected]>
Hmm, I just tried the same trick on the QDAC2 driver, and it did not work as expected, that is, the timeout was not overridden... If that is the case, the patch will make the driver somewhat unusable. |
this is strange. note that the |
Of course it is in seconds (https://www.youtube.com/watch?v=QfnC_3Uxj2I) So the value has to be divided by thousand. I am not sure how to do it here in Github though... |
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 20.64% 20.60% -0.04%
==========================================
Files 134 134
Lines 16824 16852 +28
==========================================
Hits 3473 3473
- Misses 13351 13379 +28
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@jpsecher i see that you managed to to change set_to to 0.001 - is everything working now? if so, let's merge? |
@jpsecher could you merge the latest gratest main into your branch? then the Pr will be merged automatically |