Add QDevil QDAC 1 driver imported from Qcodes #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
commented
Jan 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 21.23% 20.64% -0.59%
==========================================
Files 130 131 +1
Lines 16083 16540 +457
==========================================
Hits 3415 3415
- Misses 12668 13125 +457
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@jpsecher FYI |
jenshnielsen
force-pushed
the
add_qdevil1
branch
from
44c366f to
d5c3a72
Compare
|
Would it make sense to name it |
Make new driver for the QDevil QDAC based on the existing QDac_channels driver, originally made for the QDAC prototypes assembled at the Niels Bohr Institute
Driver for the QDevil QDAC. It is based on the “QDev\Qdac_channels.py” driver but is different in many ways as it leverages several of the latest developments from QDevil, and requires a QDAC from QDevil with at least firmware 1.07. The improvements include auto configuration, output calibration, and synchronised multi-channel ramping.
… it is not executed during automatic tests Removed unused imports from drivers Replaced parameter .get_latest by .cache and ._save_val by .cache.set
Apply most changes suggested in review, and changed behavior to not touch the outputs at initialisation. The QDAC state is instead read at initialisation leaving any on going ramping to continue, thus restoring the internal generator book keeping. A reset command is added to make it possible to reset all parameters to default values.
Co-authored-by: Mikhail Astafev <[email protected]>
jenshnielsen
force-pushed
the
add_qdevil1
branch
from
d5c3a72 to
972bd44
Compare
|
@jpsecher Done |
astafan8
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference the export was done with
Which was then merged with a local remote into this repo
closes #194