Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin packaging to < 22 for drivers using legacy versions and pin ipython to 8.6 #183

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

jenshnielsen
Copy link
Collaborator

No description provided.

@jenshnielsen jenshnielsen changed the title Pin packaging to < 22 for drivers using legacy versions Pin packaging to < 22 for drivers using legacy versions and pin ipython to 8.6 Dec 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #183 (087c667) into main (c1ed848) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   19.38%   19.38%           
=======================================
  Files         125      126    +1     
  Lines       15700    15701    +1     
=======================================
+ Hits         3043     3044    +1     
  Misses      12657    12657           
Impacted Files Coverage Δ
qcodes_contrib_drivers/__init__.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Dec 12, 2022

@jpsecher The QDAC II version comparison logic makes use of legacy versions which have been removed in packaging 22.0. Here I have pinned it to an older version but it would be nice to update the logic to not have this issue.

In QCoDeS we implemented some logic that modifies version numbers to be consistent. Alternatively you may have to implement your own logic. https://qcodes.github.io/Qcodes/api/utils/index.html#qcodes.utils.convert_legacy_version_to_supported_version

@jenshnielsen jenshnielsen merged commit 3f0d7c9 into QCoDeS:main Dec 12, 2022
@jpsecher
Copy link
Contributor

jpsecher commented Dec 13, 2022 via email

@jenshnielsen
Copy link
Collaborator Author

Cool we can remove the pin once #180 is removed.
I was under the impression that if you reply to a email comment they should normally end up here too (but perhaps you need reply all) I don't use email for my github notefications personally so a bit unsure

@jenshnielsen jenshnielsen deleted the pyproject_toml branch December 13, 2022 14:24
@jpsecher
Copy link
Contributor

jpsecher commented Dec 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants