-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin packaging to < 22 for drivers using legacy versions and pin ipython to 8.6 #183
Conversation
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 19.38% 19.38%
=======================================
Files 125 126 +1
Lines 15700 15701 +1
=======================================
+ Hits 3043 3044 +1
Misses 12657 12657
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@jpsecher The QDAC II version comparison logic makes use of legacy versions which have been removed in packaging 22.0. Here I have pinned it to an older version but it would be nice to update the logic to not have this issue. In QCoDeS we implemented some logic that modifies version numbers to be consistent. Alternatively you may have to implement your own logic. https://qcodes.github.io/Qcodes/api/utils/index.html#qcodes.utils.convert_legacy_version_to_supported_version |
I have implemented my own version logic (because the first part of the
qdac2 version concerns the fpga and has no effect on the driver).
PS: I just realised that I have been replying to these messages from
Github by hitting Reply, which then wrongly goes to Jens Hedegaard
Nielsen ***@***.***>, so I guess you never got any of the
emails I sent, I guess...
Cheers,
/JP
…On 12/12/2022 12.55, Jens Hedegaard Nielsen wrote:
@jpsecher <https://github.com/jpsecher> The QDAC II version comparison
logic makes use of legacy versions which have been removed in packaging
22.0. Here I have pinned it to an older version but it would be nice to
update the logic to not have this issue.
In QCoDeS we implemented some logic that modifies version numbers to be
consistent. Alternatively you may have to implement your own logic.
|
Cool we can remove the pin once #180 is removed. |
FYI it was a problem with Thunderbird that for some reason has changed
the default setting.
Cheers,
/JP
…On 13/12/2022 15.24, Jens Hedegaard Nielsen wrote:
I was under the impression that if you reply to a email comment they
should normally end up here too (but perhaps you need reply all) I don't
use email for my github notefications personally so a bit unsure
|
No description provided.