Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDevil QDAC2: Update to agree with new firmware #154

Merged
merged 11 commits into from
Sep 9, 2022

Conversation

jpsecher
Copy link
Contributor

@jpsecher jpsecher commented Sep 7, 2022

  • Accept shorter version numbers
  • Sleep after reset (*RST)
  • Update examples

requirements.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #154 (584d1d7) into master (214df35) will increase coverage by 0.02%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   18.39%   18.41%   +0.02%     
==========================================
  Files         124      124              
  Lines       15451    15454       +3     
==========================================
+ Hits         2842     2846       +4     
+ Misses      12609    12608       -1     
Impacted Files Coverage Δ
...b_drivers/tests/QDevil/test_real_qdac2_ieee_std.py 42.30% <0.00%> (-0.55%) ⬇️
...contrib_drivers/tests/QDevil/test_sim_qdac2_awg.py 100.00% <ø> (ø)
...trib_drivers/tests/QDevil/test_sim_qdac2_square.py 100.00% <ø> (ø)
...ib_drivers/tests/QDevil/test_sim_qdac2_triangle.py 100.00% <ø> (ø)
qcodes_contrib_drivers/drivers/QDevil/QDAC2.py 96.38% <100.00%> (+0.01%) ⬆️
...ib_drivers/tests/QDevil/test_sim_qdac2_ieee_std.py 100.00% <100.00%> (ø)
...ontrib_drivers/tests/QDevil/test_sim_qdac2_sine.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@astafan8 astafan8 changed the title Update to agree with new firmware QDevil QDAC2: Update to agree with new firmware Sep 9, 2022
@astafan8 astafan8 merged commit 301c25c into QCoDeS:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants