R&S ZVL13 Vector Network Analyzer driver #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a Qcodes driver for R&S®ZVL13 Vector Network Analyzer (https://www.rohde-schwarz.com/fi/product/zvl13-options_63490-10575.html). The code is based on the already existing ZNB Qcodes driver (https://qcodes.github.io/Qcodes/_modules/qcodes/instrument_drivers/rohde_schwarz/ZNB.html) but is completely adapted to the ZVL-13 model.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 19.25% 18.90% -0.36%
==========================================
Files 123 124 +1
Lines 14659 14935 +276
==========================================
Hits 2823 2823
- Misses 11836 12112 +276
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Thank you for your time to review the code and improve it. Sorry for the additional pull request!
Best,
PM
Inviato da Posta<https://go.microsoft.com/fwlink/?LinkId=550986> per Windows
Da: Mikhail ***@***.***>
Inviato: martedì 12 luglio 2022 10:22
A: ***@***.***>
Cc: Pasquale ***@***.***>; ***@***.***>
Oggetto: Re: [QCoDeS/Qcodes_contrib_drivers] R&S ZVL13 Vector Network Analyzer driver (PR #139)
@astafan8 approved this pull request.
thank you @Pask97<https://github.com/Pask97> ! I've edited the driver a little bit for readability.
Also, you don't have to create a separate pull request for the example notebook, it can come together with the driver :)
—
Reply to this email directly, view it on GitHub<#139 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWKDIFDGXW7KRUSPHAJX3T3VTUTLVANCNFSM53I4YG5Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Qcodes driver for R&S®ZVL13 Vector Network Analyzer (https://www.rohde-schwarz.com/fi/product/zvl13-options_63490-10575.html).
The code is based on the already existing ZNB Qcodes driver (https://qcodes.github.io/Qcodes/_modules/qcodes/instrument_drivers/rohde_schwarz/ZNB.html) but is completely adapted to the ZVL-13 model.