Skip to content

Analog modulation for NI RFSG driver #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2022

Conversation

mgunyho
Copy link
Contributor

@mgunyho mgunyho commented May 24, 2022

Add functionality to enable analog (amplitude / frequency / phase) modulation for NI-RFSG based devices. Includes example code in the example notebook. Tested amplitude modulation with a PXIe-5654.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #130 (60758d6) into master (2fd9c39) will decrease coverage by 0.66%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   19.91%   19.25%   -0.67%     
==========================================
  Files         121      123       +2     
  Lines       14708    14627      -81     
==========================================
- Hits         2929     2816     -113     
- Misses      11779    11811      +32     
Impacted Files Coverage Δ
...ontrib_drivers/drivers/NationalInstruments/RFSG.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/__init__.py 100.00% <0.00%> (ø)
...es_contrib_drivers/drivers/CopperMountain/M5180.py 0.00% <0.00%> (ø)
...contrib_drivers/drivers/NationalInstruments/DAQ.py 0.00% <0.00%> (ø)
...contrib_drivers/drivers/Tektronix/Keithley_6500.py 0.00% <0.00%> (ø)
...ontrib_drivers/tests/QDevil/test_sim_qdac2_init.py 100.00% <0.00%> (ø)
...rib_drivers/tests/QDevil/test_sim_qdac2_current.py 100.00% <0.00%> (ø)
..._contrib_drivers/drivers/GeneralMicrowave/GM349.py 0.00% <0.00%> (ø)
...codes_contrib_drivers/drivers/Holzworth/HS9008B.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/drivers/QDevil/QDAC2.py 96.35% <0.00%> (+0.02%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@astafan8 astafan8 force-pushed the rfsg-analog-modulation branch from f020488 to f8cc442 Compare May 24, 2022 07:43
@astafan8 astafan8 enabled auto-merge May 24, 2022 07:43
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@astafan8 astafan8 merged commit c6adadd into QCoDeS:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants