Two 2D scan examples & refuse non-identifier instrument name #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
+ Coverage 19.43% 19.49% +0.05%
==========================================
Files 121 121
Lines 14438 14448 +10
==========================================
+ Hits 2806 2816 +10
Misses 11632 11632
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
astafan8
approved these changes
Apr 22, 2022
| @@ -2170,3 +2171,10 @@ def _set_up_manual_triggers(self) -> None: | |||
| def _set_up_simple_functions(self) -> None: | |||
| self.add_function('reset', call_cmd='*rst') | |||
| self.add_function('abort', call_cmd='abor') | |||
|
|
|||
| def _check_instrument_name(self, name: str) -> None: | |||
There was a problem hiding this comment.
stricktly qcodes does not prescribe this requirement for instrument names. but perhaps it should? could you explain when did it become a problem for qdac?
There was a problem hiding this comment.
The doNd functions break when the instrument name is not isidentifier()
astafan8
reviewed
Apr 22, 2022
There was a problem hiding this comment.
for the new notebooks, don't forget to disable execution in the docs build, read here how to do that https://qcodes.github.io/Qcodes/examples/writing_drivers/Creating-Instrument-Drivers.html#Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.