Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDevil: Correct typo in init file #119

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 23, 2022

@jpsecher

  • Python files are only packaged if you include a __init__.py file in the folder not a __init_.py file
  • Do you want the yaml files to be part of the package or Are they only indended to be there for running tests from source.

If you want to include the files then then should be included as pacakge data in setup.cfg
Compare https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/master/setup.cfg to
https://github.com/QCoDeS/Qcodes/blob/master/setup.cfg#L55

@jenshnielsen jenshnielsen merged commit 2fd9c39 into master Feb 23, 2022
@jenshnielsen jenshnielsen deleted the qdevil_fix_packaging branch February 23, 2022 11:51
@jpsecher
Copy link
Contributor

Ahh, a typo, thanks!

I don't think the simulation needs to be included.

@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Feb 23, 2022

Ok great I will tag a new release asap

@jenshnielsen
Copy link
Collaborator Author

@jpsecher 0.13.1 is released to pypi https://pypi.org/project/qcodes-contrib-drivers/ can you check that it works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants